fix organizer diagnostics and site integrations

internal/service/organize_pipeline_test.go

@@ -1,8 +1,12 @@
 package service
 
 import (
+	"errors"
 	"path/filepath"
+	"strings"
 	"testing"
+
+	"go.uber.org/zap"
 )
 
 func TestOrganizeScanRootUsesActualOrganizedTarget(t *testing.T) {
@@ -35,3 +39,49 @@ func TestOrganizeScanRootUsesCommonAffectedCategoryRoot(t *testing.T) {
 		t.Fatalf("organizeScanRoot() = %q, want %q", got, root)
 	}
 }
+
+func TestOrganizePipelineFailsWhenEveryOrganizeItemErrors(t *testing.T) {
+	root := t.TempDir()
+	src := filepath.Join(root, "downloads")
+	dest := filepath.Join(root, "media")
+	writeOrgFile(t, filepath.Join(src, "Dune 2021 1080p.mkv"), "movie")
+
+	origLinkFile := linkFile
+	linkFile = func(_, _ string) error {
+		return errors.New("cross-device link")
+	}
+	t.Cleanup(func() { linkFile = origLinkFile })
+
+	repos := newOrganizerTestRepo(t)
+	organizer := NewOrganizerService(nil, zap.NewNop(), repos)
+	tasks := NewTaskTrackerService(zap.NewNop(), nil)
+	pipeline := NewOrganizePipelineService(zap.NewNop(), repos, organizer, nil, tasks)
+
+	_, err := pipeline.Run(t.Context(), OrganizePipelineRequest{
+		Scope:        OrganizeScopeDirectory,
+		Trigger:      OrganizeTriggerScheduled,
+		SourcePath:   src,
+		DestPath:     dest,
+		TransferMode: string(TransferHardlink),
+	})
+	if err == nil {
+		t.Fatal("expected organize pipeline to fail when every item errors")
+	}
+	if !strings.Contains(err.Error(), "organize failed") || !strings.Contains(err.Error(), "hardlink failed") {
+		t.Fatalf("error = %q, want organize failure with hardlink detail", err.Error())
+	}
+	snap := tasks.Snapshot()
+	if len(snap.Recent) != 1 {
+		t.Fatalf("recent tasks = %d, want 1", len(snap.Recent))
+	}
+	task := snap.Recent[0]
+	if task.Status != TaskStatusFailed {
+		t.Fatalf("task status = %q, want failed", task.Status)
+	}
+	if !strings.Contains(task.Error, "hardlink failed") {
+		t.Fatalf("task error = %q, want hardlink detail", task.Error)
+	}
+	if len(task.Details) == 0 || !strings.Contains(task.Details[0], "cross-device link") {
+		t.Fatalf("task details = %#v, want transfer error detail", task.Details)
+	}
+}