后端与全仓代码质量清理（golangci 扩展集 · 测试质量 · 并发安全 · 文档同步）

代码质量全量清理，零行为变化：golangci 扩展集 13 类 linter（gosec/modernize/perfsprint/canonicalheader/usestdlibvars/wastedassign/intrange/errorlint/forcetypeassert/recvcheck/exhaustive/unparam）全量修复，测试代码质量（testifylint/thelper/usetesting）25→0，frpc 进程生命周期真 bug（进程组击杀）、全仓 go test -race 6 类数据竞争（含 1 个生产竞争）、SPDX license 头补齐 131 文件、前端测试套件 next-intl 迁移后 44 失败→全绿、过期 swagger 文档重新生成、pnpm-workspace 构建审批。

Experiments: #2-#17, #18, #20, #21, #23
Metric: total_issues 108 → 8 (-92.6%)

pkg/logger/logger.go

@@ -78,25 +78,25 @@ func Init(cfg Config) {
 }
 
 // DebugF 输出 Debug 级别日志
-func DebugF(ctx context.Context, format string, args ...interface{}) {
+func DebugF(ctx context.Context, format string, args ...any) {
 	msg := fmt.Sprintf(format, args...)
 	logger.Ctx(ctx).Debug(msg, getTraceIDFields(ctx)...)
 }
 
 // InfoF 输出 Info 级别日志
-func InfoF(ctx context.Context, format string, args ...interface{}) {
+func InfoF(ctx context.Context, format string, args ...any) {
 	msg := fmt.Sprintf(format, args...)
 	logger.Ctx(ctx).Info(msg, getTraceIDFields(ctx)...)
 }
 
 // WarnF 输出 Warn 级别日志
-func WarnF(ctx context.Context, format string, args ...interface{}) {
+func WarnF(ctx context.Context, format string, args ...any) {
 	msg := fmt.Sprintf(format, args...)
 	logger.Ctx(ctx).Warn(msg, getTraceIDFields(ctx)...)
 }
 
 // ErrorF 输出 Error 级别日志
-func ErrorF(ctx context.Context, format string, args ...interface{}) {
+func ErrorF(ctx context.Context, format string, args ...any) {
 	msg := fmt.Sprintf(format, args...)
 	logger.Ctx(ctx).Error(msg, getTraceIDFields(ctx)...)
 }

pkg/logger/ringbuffer.go

@@ -47,7 +47,7 @@ func (r *LogRingBuffer) Write(p []byte) (int, error) {
 
 	data := string(p)
 	start := 0
-	for i := 0; i < len(data); i++ {
+	for i := range len(data) {
 		if data[i] == '\n' {
 			line := data[start:i]
 			start = i + 1
@@ -114,7 +114,7 @@ func (r *LogRingBuffer) Query(cursor int, limit int) ([]LogEntry, bool) {
 
 	// 将 ring buffer 中的有效条目按顺序收集
 	ordered := make([]LogEntry, 0, r.count)
-	for i := 0; i < r.count; i++ {
+	for i := range r.count {
 		pos := (oldestPos + i) % r.cap
 		ordered = append(ordered, r.entries[pos])
 	}
@@ -141,10 +141,7 @@ func (r *LogRingBuffer) Query(cursor int, limit int) ([]LogEntry, bool) {
 	}
 
 	// 返回 cut 之前的最后 limit 条
-	start := cut - limit
-	if start < 0 {
-		start = 0
-	}
+	start := max(cut-limit, 0)
 
 	hasMore := start > 0
 	return ordered[start:cut], hasMore

pkg/logger/ringbuffer_test.go

@@ -8,6 +8,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 )
 
 func TestLogRingBuffer_WriteAndQuery(t *testing.T) {
@@ -18,7 +19,7 @@ func TestLogRingBuffer_WriteAndQuery(t *testing.T) {
 
 	entries, hasMore := rb.Query(0, 10)
 	assert.False(t, hasMore)
-	assert.Equal(t, 3, len(entries))
+	assert.Len(t, entries, 3)
 	assert.Equal(t, "line1", entries[0].Data)
 	assert.Equal(t, "line2", entries[1].Data)
 	assert.Equal(t, "line3", entries[2].Data)
@@ -34,7 +35,7 @@ func TestLogRingBuffer_CapacityOverflow(t *testing.T) {
 
 	entries, hasMore := rb.Query(0, 10)
 	assert.False(t, hasMore)
-	assert.Equal(t, 3, len(entries))
+	assert.Len(t, entries, 3)
 	assert.Equal(t, "c", entries[0].Data)
 	assert.Equal(t, "d", entries[1].Data)
 	assert.Equal(t, "e", entries[2].Data)
@@ -48,7 +49,7 @@ func TestLogRingBuffer_QueryLatest(t *testing.T) {
 	// Query latest 2
 	entries, hasMore := rb.Query(0, 2)
 	assert.True(t, hasMore)
-	assert.Equal(t, 2, len(entries))
+	assert.Len(t, entries, 2)
 	assert.Equal(t, "d", entries[0].Data)
 	assert.Equal(t, "e", entries[1].Data)
 }
@@ -60,12 +61,12 @@ func TestLogRingBuffer_QueryByCursor(t *testing.T) {
 
 	// First get all to find indices
 	all, _ := rb.Query(0, 10)
-	assert.Equal(t, 5, len(all))
+	assert.Len(t, all, 5)
 
 	// Query entries before index 3
 	entries, hasMore := rb.Query(3, 10)
 	assert.False(t, hasMore)
-	assert.Equal(t, 3, len(entries))
+	assert.Len(t, entries, 3)
 	assert.Equal(t, "a", entries[0].Data)
 	assert.Equal(t, "b", entries[1].Data)
 	assert.Equal(t, "c", entries[2].Data)
@@ -79,7 +80,7 @@ func TestLogRingBuffer_QueryByCursorWithLimit(t *testing.T) {
 	// Query 2 entries before index 4
 	entries, hasMore := rb.Query(4, 2)
 	assert.True(t, hasMore)
-	assert.Equal(t, 2, len(entries))
+	assert.Len(t, entries, 2)
 	assert.Equal(t, "c", entries[0].Data)
 	assert.Equal(t, "d", entries[1].Data)
 }
@@ -98,7 +99,7 @@ func TestLogRingBuffer_QueryNonExistentCursor(t *testing.T) {
 
 	entries, hasMore := rb.Query(999, 10)
 	assert.False(t, hasMore)
-	assert.Equal(t, 2, len(entries))
+	assert.Len(t, entries, 2)
 	assert.Equal(t, "a", entries[0].Data)
 	assert.Equal(t, "b", entries[1].Data)
 }
@@ -138,7 +139,7 @@ func TestLogRingBuffer_WriteNoNewline(t *testing.T) {
 	_, _ = rb.Write([]byte("partial"))
 
 	entries, _ := rb.Query(0, 10)
-	assert.Equal(t, 1, len(entries))
+	assert.Len(t, entries, 1)
 	assert.Equal(t, "partial", entries[0].Data)
 }
 
@@ -147,7 +148,7 @@ func TestLogRingBuffer_WriteEmpty(t *testing.T) {
 
 	n, err := rb.Write([]byte(""))
 	assert.Equal(t, 0, n)
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	entries, _ := rb.Query(0, 10)
 	assert.Nil(t, entries)
@@ -160,7 +161,7 @@ func TestLogRingBuffer_QueryAfterOverflow(t *testing.T) {
 
 	entries, hasMore := rb.Query(0, 10)
 	assert.False(t, hasMore)
-	assert.Equal(t, 3, len(entries))
+	assert.Len(t, entries, 3)
 	assert.Equal(t, "5", entries[0].Data)
 	assert.Equal(t, "6", entries[1].Data)
 	assert.Equal(t, "7", entries[2].Data)
@@ -178,14 +179,14 @@ func TestLogRingBuffer_NextCursor(t *testing.T) {
 
 	// Query latest 2, should return next_cursor pointing to first returned entry
 	entries, _ := rb.Query(0, 2)
-	assert.Equal(t, 2, len(entries))
+	assert.Len(t, entries, 2)
 	// entries[0].Index = 3 ("d"), entries[1].Index = 4 ("e")
 	assert.Equal(t, 3, entries[0].Index)
 
 	// Now use that index as cursor to get older entries
 	older, hasMore := rb.Query(entries[0].Index, 10)
 	assert.False(t, hasMore)
-	assert.Equal(t, 3, len(older))
+	assert.Len(t, older, 3)
 	assert.Equal(t, "a", older[0].Data)
 	assert.Equal(t, "b", older[1].Data)
 	assert.Equal(t, "c", older[2].Data)