fix lint

internal/apps/openflare/observability/access_log_logics.go

@@ -1,6 +1,4 @@
-// Copyright 2026 Arctel.net
-// SPDX-License-Identifier: Apache-2.0
-
+// Package observability provides monitoring, metrics, and access log analysis for OpenFlare.
 package observability
 
 import (
@@ -22,6 +20,8 @@ const (
 	defaultIPTrendBucketMinute = 30
 	maxIPTrendHours            = 168
 	nodeAccessLogRetentionDays = 90
+	accessLogFieldRemoteAddr   = "remote_addr"
+	accessLogFieldRequestCount = "request_count"
 )
 
 var nodeAccessLogRetentionWindow = nodeAccessLogRetentionDays * 24 * time.Hour
@@ -524,9 +524,9 @@ func normalizeFoldedAccessLogIPQuery(input FoldedAccessLogIPQuery) (FoldedAccess
 	}
 	normalizedSortBy := strings.TrimSpace(input.SortBy)
 	switch normalizedSortBy {
-	case "last_seen_at", "remote_addr":
+	case "last_seen_at", accessLogFieldRemoteAddr:
 	default:
-		normalizedSortBy = "request_count"
+		normalizedSortBy = accessLogFieldRequestCount
 	}
 	return FoldedAccessLogIPQuery{
 		NodeID:          strings.TrimSpace(input.NodeID),
@@ -591,7 +591,7 @@ func normalizeAccessLogPageSize(pageSize int) int {
 
 func normalizeAccessLogSortBy(sortBy string) string {
 	switch strings.TrimSpace(sortBy) {
-	case "status_code", "remote_addr", "host", "path":
+	case "status_code", accessLogFieldRemoteAddr, "host", "path":
 		return strings.TrimSpace(sortBy)
 	default:
 		return defaultAccessLogSortBy
@@ -607,8 +607,8 @@ func normalizeAccessLogSortOrder(sortOrder string) string {
 
 func normalizeFoldSortBy(sortBy string) string {
 	switch strings.TrimSpace(sortBy) {
-	case "request_count":
-		return "request_count"
+	case accessLogFieldRequestCount:
+		return accessLogFieldRequestCount
 	default:
 		return "bucket_started_at"
 	}
@@ -616,7 +616,7 @@ func normalizeFoldSortBy(sortBy string) string {
 
 func normalizeIPSummarySortBy(sortBy string) string {
 	switch strings.TrimSpace(sortBy) {
-	case "recent_requests", "last_seen_at", "remote_addr":
+	case "recent_requests", "last_seen_at", accessLogFieldRemoteAddr:
 		return strings.TrimSpace(sortBy)
 	default:
 		return "total_requests"

internal/apps/openflare/observability/analytics.go

@@ -19,6 +19,7 @@ const (
 	healthEventStatusResolved = "resolved"
 	healthSeverityCritical    = "critical"
 	healthSeverityWarning     = "warning"
+	percentageMultiplier      = 100
 )
 
 // DistributionItem is a key/value distribution entry.
@@ -415,7 +416,7 @@ func Percentage(used int64, total int64) float64 {
 	if used <= 0 || total <= 0 {
 		return 0
 	}
-	return (float64(used) / float64(total)) * 100
+	return (float64(used) / float64(total)) * percentageMultiplier
 }
 
 func mergeJSONCounts(target distributionAccumulator, raw string) {

internal/apps/openflare/observability/node_logics.go

@@ -14,9 +14,10 @@ import (
 )
 
 const (
-	defaultObservabilityWindow = 24 * time.Hour
-	defaultObservabilityLimit  = 120
-	maxObservabilityLimit      = 500
+	defaultObservabilityWindow      = 24 * time.Hour
+	defaultObservabilityLimit       = 120
+	maxObservabilityLimit           = 500
+	defaultTrafficDistributionLimit = 8
 )
 
 // NodeQuery filters node observability data.
@@ -106,7 +107,7 @@ func GetNodeObservability(ctx context.Context, id uint, query NodeQuery) (*NodeV
 	if err != nil {
 		return nil, err
 	}
-	accessLogRegions, err := model.ListOpenFlareAccessLogRegionCounts(ctx, node.NodeID, since, 8)
+	accessLogRegions, err := model.ListOpenFlareAccessLogRegionCounts(ctx, node.NodeID, since, defaultTrafficDistributionLimit)
 	if err != nil {
 		return nil, err
 	}
@@ -135,7 +136,7 @@ func GetNodeObservability(ctx context.Context, id uint, query NodeQuery) (*NodeV
 		HealthEvents:    events,
 		Analytics: NodeAnalytics{
 			Traffic:       buildTrafficWindowSummary(latestTrafficReport(reports)),
-			Distributions: BuildTrafficDistributions(reports, accessLogRegions, 8),
+			Distributions: BuildTrafficDistributions(reports, accessLogRegions, defaultTrafficDistributionLimit),
 			Health:        buildHealthSummary(latestMetricSnapshot(snapshots), latestTrafficReport(reports), events),
 		},
 		Trends: NodeTrends{

internal/apps/openflare/observability/routers.go

@@ -40,7 +40,7 @@ func GetAccessLogsHandler(c *gin.Context) {
 	c.JSON(http.StatusOK, response.OK(logs))
 }
 
-// getFoldedAccessLogsHandler 分页列出折叠访问日志。
+// GetFoldedAccessLogsHandler 分页列出折叠访问日志。
 // @Summary 列出折叠访问日志
 // @Description 按时间桶聚合访问日志并分页返回，需要管理员权限
 // @Tags openflare-observability
@@ -71,7 +71,7 @@ func GetFoldedAccessLogsHandler(c *gin.Context) {
 	c.JSON(http.StatusOK, response.OK(logs))
 }
 
-// getFoldedAccessLogIPsHandler 列出折叠桶内的 IP 汇总。
+// GetFoldedAccessLogIPsHandler 列出折叠桶内的 IP 汇总。
 // @Summary 列出折叠访问日志 IP 汇总
 // @Description 在指定时间桶内按 IP 聚合访问统计，需要管理员权限
 // @Tags openflare-observability
@@ -112,7 +112,7 @@ func GetFoldedAccessLogIPsHandler(c *gin.Context) {
 	c.JSON(http.StatusOK, response.OK(result))
 }
 
-// getAccessLogIPSummariesHandler 列出访问日志 IP 汇总。
+// GetAccessLogIPSummariesHandler 列出访问日志 IP 汇总。
 // @Summary 列出访问日志 IP 汇总
 // @Description 按 IP 聚合访问日志统计并分页返回，需要管理员权限
 // @Tags openflare-observability
@@ -147,7 +147,7 @@ func GetAccessLogIPSummariesHandler(c *gin.Context) {
 	c.JSON(http.StatusOK, response.OK(result))
 }
 
-// getAccessLogIPTrendHandler 获取 IP 访问趋势。
+// GetAccessLogIPTrendHandler 获取 IP 访问趋势。
 // @Summary 获取访问日志 IP 趋势
 // @Description 返回指定 IP 在时间范围内的访问趋势数据，需要管理员权限
 // @Tags openflare-observability
@@ -178,7 +178,7 @@ func GetAccessLogIPTrendHandler(c *gin.Context) {
 	c.JSON(http.StatusOK, response.OK(result))
 }
 
-// cleanupAccessLogsHandler 清理过期访问日志。
+// CleanupAccessLogsHandler 清理过期访问日志。
 // @Summary 清理访问日志
 // @Description 按保留天数清理过期访问日志记录，需要管理员权限
 // @Tags openflare-observability
@@ -220,4 +220,4 @@ func readAccessLogQuery(c *gin.Context) AccessLogQuery {
 func readQueryInt(c *gin.Context, key string) int {
 	value, _ := strconv.Atoi(c.DefaultQuery(key, "0"))
 	return value
-}
+}