fix lint

2026-10-11 01:36:37 +08:00 · 2026-06-19 15:13:24 +08:00
parent 0b34792709
commit 32861c5db9
376 changed files with 3648 additions and 19957 deletions
@@ -4,6 +4,7 @@
 package option

 import (
+	"errors"
 	"fmt"
 	"regexp"
 	"strconv"
@@ -13,6 +14,8 @@ import (
 	"github.com/Rain-kl/Wavelet/internal/model"
 )

+const maxOpenRestyGzipCompLevel = 9
+
 var (
 	openRestySizePattern          = regexp.MustCompile(`^\d+[kKmMgG]?$`)
 	openRestyProxyBuffersPattern  = regexp.MustCompile(`^\d+\s+\d+[kKmMgG]?$`)
@@ -20,6 +23,8 @@ var (
 	openRestyDurationTokenPattern = regexp.MustCompile(`^\d+[smhdwSMHDW]$`)
 )

+const optionValueTrue = "true"
+
 func buildOptionValidationState(options []model.OpenFlareOption) map[string]string {
 	model.OptionMapRWMutex.RLock()
 	state := make(map[string]string, len(model.OptionMap)+len(options))
@@ -37,11 +42,11 @@ func buildOptionValidationState(options []model.OpenFlareOption) map[string]stri
 func validateOptionWithState(option model.OpenFlareOption, state map[string]string) error {
 	switch option.Key {
 	case "GitHubOAuthEnabled":
-		if option.Value == "true" && strings.TrimSpace(state["GitHubClientId"]) == "" {
+		if option.Value == optionValueTrue && strings.TrimSpace(state["GitHubClientId"]) == "" {
 			return fmt.Errorf("无法启用 GitHub OAuth，请先填入 GitHub Client ID 以及 GitHub Client Secret！")
 		}
 	case "WeChatAuthEnabled":
-		if option.Value == "true" && strings.TrimSpace(state["WeChatServerAddress"]) == "" {
+		if option.Value == optionValueTrue && strings.TrimSpace(state["WeChatServerAddress"]) == "" {
 			return fmt.Errorf("无法启用微信登录，请先填入微信登录相关配置信息！")
 		}
 	}
@@ -71,7 +76,7 @@ func validatePositiveIntegerOption(key, value string) error {

 func validateBooleanOption(key, value string) error {
 	switch value {
-	case "true", "false":
+	case optionValueTrue, "false":
 		return nil
 	default:
 		return fmt.Errorf("%s 必须为 true 或 false", key)
@@ -112,171 +117,81 @@ func validateUptimeKumaOption(key, value string, state map[string]string) error
 	trimmed := strings.TrimSpace(value)
 	switch key {
 	case "UptimeKumaEnabled":
-		if err := validateBooleanOption(key, trimmed); err != nil {
-			return err
-		}
-		if trimmed == "true" {
-			url := strings.TrimSpace(state["UptimeKumaUrl"])
-			username := strings.TrimSpace(state["UptimeKumaUsername"])
-			password := strings.TrimSpace(state["UptimeKumaPassword"])
-			if url == "" {
-				return fmt.Errorf("启用 Uptime Kuma 时地址不能为空")
-			}
-			if username == "" {
-				return fmt.Errorf("启用 Uptime Kuma 时用户名不能为空")
-			}
-			if password == "" && model.UptimeKumaPassword == "" {
-				return fmt.Errorf("启用 Uptime Kuma 时密码不能为空")
-			}
-		}
+		return validateUptimeKumaEnabled(key, trimmed, state)
 	case "UptimeKumaUsername":
-		if trimmed == "" && state["UptimeKumaEnabled"] == "true" {
-			return fmt.Errorf("启用 Uptime Kuma 时用户名不能为空")
-		}
+		return validateUptimeKumaUsername(trimmed, state)
 	case "UptimeKumaUrl":
-		if trimmed != "" && !strings.HasPrefix(trimmed, "http://") && !strings.HasPrefix(trimmed, "https://") {
-			return fmt.Errorf("Uptime Kuma 地址必须以 http:// 或 https:// 开头")
-		}
+		return validateUptimeKumaURL(trimmed)
 	case "UptimeKumaMonitorScope":
-		if trimmed != "all" && trimmed != "selected" {
-			return fmt.Errorf("监控范围必须为全部站点 (all) 或选择站点 (selected)")
-		}
+		return validateUptimeKumaMonitorScope(trimmed)
 	case "UptimeKumaSyncInterval", "UptimeKumaInterval", "UptimeKumaRetryInterval", "UptimeKumaTimeout":
 		return validatePositiveIntegerOption(key, trimmed)
 	case "UptimeKumaRetry":
-		intValue, err := strconv.Atoi(trimmed)
-		if err != nil || intValue < 0 {
-			return fmt.Errorf("%s 必须为大于等于 0 的整数", key)
-		}
+		return validateUptimeKumaRetry(key, trimmed)
 	}
 	return nil
 }

-func validateOpenRestyOption(key, value string) error {
-	trimmed := strings.TrimSpace(value)
+func validateUptimeKumaEnabled(key, trimmed string, state map[string]string) error {
+	if err := validateBooleanOption(key, trimmed); err != nil {
+		return err
+	}
+	if trimmed != optionValueTrue {
+		return nil
+	}
+	url := strings.TrimSpace(state["UptimeKumaUrl"])
+	username := strings.TrimSpace(state["UptimeKumaUsername"])
+	password := strings.TrimSpace(state["UptimeKumaPassword"])
+	if url == "" {
+		return fmt.Errorf("启用 Uptime Kuma 时地址不能为空")
+	}
+	if username == "" {
+		return fmt.Errorf("启用 Uptime Kuma 时用户名不能为空")
+	}
+	if password == "" && model.UptimeKumaPassword == "" {
+		return fmt.Errorf("启用 Uptime Kuma 时密码不能为空")
+	}
+	return nil
+}

-	switch key {
-	case "OpenRestyDefaultServerReturnStatus":
-		if err := validatePositiveIntegerOption(key, trimmed); err != nil {
-			return err
-		}
-		statusCode, _ := strconv.Atoi(trimmed)
-		if statusCode < 100 || statusCode > 999 {
-			return fmt.Errorf("%s 必须在 100 到 999 之间", key)
-		}
-	case "OpenRestyWorkerProcesses":
-		if trimmed == "auto" {
-			return nil
-		}
-		return validatePositiveIntegerOption(key, trimmed)
-	case "OpenRestyWorkerConnections",
-		"OpenRestyWorkerRlimitNofile",
-		"OpenRestyKeepaliveTimeout",
-		"OpenRestyKeepaliveRequests",
-		"OpenRestyClientHeaderTimeout",
-		"OpenRestyClientBodyTimeout",
-		"OpenRestySendTimeout",
-		"OpenRestyProxyConnectTimeout",
-		"OpenRestyProxySendTimeout",
-		"OpenRestyProxyReadTimeout",
-		"OpenRestyGzipMinLength":
-		return validatePositiveIntegerOption(key, trimmed)
-	case "OpenRestyGzipCompLevel":
-		if err := validatePositiveIntegerOption(key, trimmed); err != nil {
-			return err
-		}
-		level, _ := strconv.Atoi(trimmed)
-		if level > 9 {
-			return fmt.Errorf("%s 不能大于 9", key)
-		}
-	case "OpenRestyEventsUse":
-		if trimmed == "" {
-			return nil
-		}
-		switch trimmed {
-		case "epoll", "kqueue", "poll", "select", "rtsig", "/dev/poll", "eventport":
-			return nil
-		default:
-			return fmt.Errorf("%s 仅支持 epoll、kqueue、poll、select、rtsig、/dev/poll、eventport 或留空", key)
-		}
-	case "OpenRestyResolvers":
-		if trimmed == "" {
-			return nil
-		}
-		if !regexp.MustCompile(`^[a-zA-Z0-9.:\-\s]+$`).MatchString(trimmed) {
-			return fmt.Errorf("%s 包含非法字符，请填入有效的 IP 地址或域名，以空格分隔", key)
-		}
-	case "OpenRestyEventsMultiAcceptEnabled",
-		"OpenRestyWebsocketEnabled",
-		"OpenRestyHTTP3Enabled",
-		"OpenRestyProxyRequestBufferingEnabled",
-		"OpenRestyProxyBufferingEnabled",
-		"OpenRestyGzipEnabled",
-		"OpenRestyCacheEnabled",
-		"OpenRestyCacheLockEnabled":
-		return validateBooleanOption(key, trimmed)
-	case "OpenRestyProxyBuffers", "OpenRestyLargeClientHeaderBuffers":
-		if openRestyProxyBuffersPattern.MatchString(trimmed) {
-			return nil
-		}
-		return fmt.Errorf("%s 格式必须类似 \"16 16k\"", key)
-	case "OpenRestyProxyBufferSize", "OpenRestyProxyBusyBuffersSize", "OpenRestyCacheMaxSize", "OpenRestyClientMaxBodySize":
-		if openRestySizePattern.MatchString(trimmed) {
-			return nil
-		}
-		return fmt.Errorf("%s 格式必须为整数或带 k/m/g 单位的大小值", key)
-	case "OpenRestyCachePath":
-		if strings.ContainsAny(trimmed, "\r\n\t") {
-			return fmt.Errorf("%s 不能包含换行或制表符", key)
-		}
-	case "OpenRestyCacheLevels":
-		if openRestyCacheLevelsPattern.MatchString(trimmed) {
-			return nil
-		}
-		return fmt.Errorf("%s 格式必须类似 \"1:2\" 或 \"1:2:2\"", key)
-	case "OpenRestyCacheInactive", "OpenRestyCacheLockTimeout":
-		if openRestyDurationTokenPattern.MatchString(trimmed) {
-			return nil
-		}
-		return fmt.Errorf("%s 格式必须为带单位的时长，例如 30m 或 5s", key)
-	case "OpenRestyCacheKeyTemplate":
-		if trimmed == "" {
-			return fmt.Errorf("%s 不能为空", key)
-		}
-		if strings.ContainsAny(trimmed, "\r\n") {
-			return fmt.Errorf("%s 不能包含换行", key)
-		}
-	case "OpenRestyCacheUseStale":
-		if trimmed == "" {
-			return fmt.Errorf("%s 不能为空", key)
-		}
-		allowedTokens := map[string]struct{}{
-			"error": {}, "timeout": {}, "invalid_header": {}, "updating": {},
-			"http_500": {}, "http_502": {}, "http_503": {}, "http_504": {},
-			"http_403": {}, "http_404": {}, "http_429": {}, "off": {},
-		}
-		for _, token := range strings.Fields(trimmed) {
-			if _, ok := allowedTokens[token]; !ok {
-				return fmt.Errorf("%s 包含不支持的值 %q", key, token)
-			}
-		}
-	case "OpenRestyMainConfigTemplate":
-		if strings.TrimSpace(value) == "" {
-			return fmt.Errorf("%s 不能为空", key)
-		}
+func validateUptimeKumaUsername(trimmed string, state map[string]string) error {
+	if trimmed == "" && state["UptimeKumaEnabled"] == optionValueTrue {
+		return fmt.Errorf("启用 Uptime Kuma 时用户名不能为空")
+	}
+	return nil
+}
+
+func validateUptimeKumaURL(trimmed string) error {
+	if trimmed != "" && !strings.HasPrefix(trimmed, "http://") && !strings.HasPrefix(trimmed, "https://") {
+		return fmt.Errorf("uptime Kuma 地址必须以 http:// 或 https:// 开头")
+	}
+	return nil
+}
+
+func validateUptimeKumaMonitorScope(trimmed string) error {
+	if trimmed != "all" && trimmed != "selected" {
+		return fmt.Errorf("监控范围必须为全部站点 (all) 或选择站点 (selected)")
+	}
+	return nil
+}
+
+func validateUptimeKumaRetry(key, trimmed string) error {
+	intValue, err := strconv.Atoi(trimmed)
+	if err != nil || intValue < 0 {
+		return fmt.Errorf("%s 必须为大于等于 0 的整数", key)
 	}
 	return nil
 }

 func validateOptions(options []model.OpenFlareOption) error {
 	if len(options) == 0 {
-		return fmt.Errorf(errInvalidParams)
+		return errors.New(errInvalidParams)
 	}

 	state := buildOptionValidationState(options)
 	for _, option := range options {
 		if strings.TrimSpace(option.Key) == "" {
-			return fmt.Errorf(errInvalidParams)
+			return errors.New(errInvalidParams)
 		}
 		if err := validateOptionWithState(option, state); err != nil {
 			return err