fix lint

internal/apps/relay/heartbeat/service.go

@@ -1,19 +1,22 @@
+// Package heartbeat sends periodic relay node status to the control plane.
 package heartbeat
 
 import (
 	"context"
 	"log/slog"
 
+	edgeheartbeat "github.com/Rain-kl/Wavelet/internal/apps/edge/heartbeat"
 	"github.com/Rain-kl/Wavelet/internal/apps/relay/config"
 	"github.com/Rain-kl/Wavelet/internal/apps/relay/frps"
 	"github.com/Rain-kl/Wavelet/internal/apps/relay/httpclient"
 	"github.com/Rain-kl/Wavelet/internal/apps/relay/observability"
 	"github.com/Rain-kl/Wavelet/internal/apps/relay/state"
-	edgeheartbeat "github.com/Rain-kl/Wavelet/internal/apps/edge/heartbeat"
 	"github.com/Rain-kl/Wavelet/internal/apps/relay/updater"
 	service "github.com/Rain-kl/Wavelet/pkg/protocol"
 )
 
+// Service sends periodic heartbeat payloads to the server, updates the frps
+// configuration from the server response, and triggers auto-update checks.
 type Service struct {
 	client      *httpclient.Client
 	frpsManager *frps.Manager
@@ -22,6 +25,8 @@ type Service struct {
 	updater     *updater.Service
 }
 
+// New constructs a Service using the provided HTTP client, frps manager,
+// configuration, and persistent state store.
 func New(client *httpclient.Client, manager *frps.Manager, cfg *config.Config, stateStore *state.Store) *Service {
 	return &Service{
 		client:      client,
@@ -32,6 +37,7 @@ func New(client *httpclient.Client, manager *frps.Manager, cfg *config.Config, s
 	}
 }
 
+// Run starts the heartbeat loop and blocks until ctx is cancelled.
 func (s *Service) Run(ctx context.Context) {
 	edgeheartbeat.RunLoop(ctx, s.config.HeartbeatInterval.Duration(), s.doHeartbeat)
 }
@@ -42,7 +48,7 @@ func (s *Service) doHeartbeat(ctx context.Context) {
 	runtimeStatus := s.frpsManager.GetRuntimeStatus()
 	payload := service.RelayHeartbeatPayload{
 		Version:         config.Version,
-		ExtVersion:      s.frpsManager.GetVersion(),
+		ExtVersion:      s.frpsManager.GetVersion(ctx),
 		RelayStatus:     runtimeStatus.Status,
 		FrpsConnCount:   runtimeStatus.Connections,
 		FrpsProxyCount:  runtimeStatus.ProxyCount,
@@ -63,10 +69,12 @@ func (s *Service) doHeartbeat(ctx context.Context) {
 	slog.Debug("heartbeat succeeded")
 
 	// Update configs if changed
-	s.frpsManager.UpdateConfig(resp.RelayConfig)
+	if resp != nil {
+		s.frpsManager.UpdateConfig(ctx, resp.RelayConfig)
 
-	if resp != nil && resp.RelaySettings != nil {
-		edgeheartbeat.TryAutoUpdate(ctx, s.updater, relaySettingsToAutoUpdate(resp.RelaySettings), "relay")
+		if resp.RelaySettings != nil {
+			edgeheartbeat.TryAutoUpdate(ctx, s.updater, relaySettingsToAutoUpdate(resp.RelaySettings), "relay")
+		}
 	}
 }