fix lint

pkg/geoip/mmdb.go

@@ -1,6 +1,7 @@
 package geoip
 
 import (
+	"context"
 	"fmt"
 	"io"
 	"net"
@@ -12,47 +13,55 @@ import (
 	"github.com/oschwald/maxminddb-golang"
 )
 
-var GeoIpUrl = "https://raw.githubusercontent.com/Loyalsoldier/geoip/release/GeoLite2-Country.mmdb"
-var GeoIpFilePath = "./data/GeoLite2-Country.mmdb"
+// GeoIPURL is the default download URL for the MaxMind GeoLite2 country database.
+var GeoIPURL = "https://raw.githubusercontent.com/Loyalsoldier/geoip/release/GeoLite2-Country.mmdb"
 
-type GeoIpRecord struct {
+// GeoIPFilePath is the default local path for the MaxMind country database file.
+var GeoIPFilePath = "./data/GeoLite2-Country.mmdb"
+
+// Record is the MaxMind database record structure for country lookups.
+type Record struct {
 	Country struct {
 		ISOCode string            `maxminddb:"iso_code"`
 		Names   map[string]string `maxminddb:"names"`
 	} `maxminddb:"country"`
 }
 
+// MaxMindGeoIPService resolves geographic information using a local MaxMind MMDB database.
 type MaxMindGeoIPService struct {
 	maxMindDBReader *maxminddb.Reader
 	dbFilePath      string
 	mu              sync.RWMutex
 }
 
+// Name returns the provider identifier for the MaxMind database service.
 func (s *MaxMindGeoIPService) Name() string {
 	return "MaxMind"
 }
 
+// NewMaxMindGeoIPService creates a MaxMind service using the default database path and URL.
 func NewMaxMindGeoIPService() (*MaxMindGeoIPService, error) {
-	return NewMaxMindGeoIPServiceWithConfig(GeoIpFilePath, GeoIpUrl)
+	return NewMaxMindGeoIPServiceWithConfig(GeoIPFilePath, GeoIPURL)
 }
 
+// NewMaxMindGeoIPServiceWithConfig creates a MaxMind service with custom database path and download URL.
 func NewMaxMindGeoIPServiceWithConfig(dbFilePath string, downloadURL string) (*MaxMindGeoIPService, error) {
 	if dbFilePath == "" {
-		dbFilePath = GeoIpFilePath
+		dbFilePath = GeoIPFilePath
 	}
 	if downloadURL == "" {
-		downloadURL = GeoIpUrl
+		downloadURL = GeoIPURL
 	}
 	service := &MaxMindGeoIPService{
 		dbFilePath: dbFilePath,
 	}
 
-	if err := os.MkdirAll(filepath.Dir(service.dbFilePath), os.ModePerm); err != nil {
+	if err := os.MkdirAll(filepath.Dir(service.dbFilePath), geoipDataDirPerm); err != nil {
 		return nil, fmt.Errorf("failed to create data directory for MaxMind database: %w", err)
 	}
 
 	if _, err := os.Stat(service.dbFilePath); os.IsNotExist(err) {
-		if err := DownloadMaxMindDatabase(service.dbFilePath, downloadURL); err != nil {
+		if err := DownloadMaxMindDatabase(context.Background(), service.dbFilePath, downloadURL); err != nil {
 			return nil, fmt.Errorf("failed to download initial MaxMind database: %w", err)
 		}
 	}
@@ -81,6 +90,7 @@ func (s *MaxMindGeoIPService) initialize() error {
 	return nil
 }
 
+// GetGeoInfo looks up geographic information for ip in the MaxMind database.
 func (s *MaxMindGeoIPService) GetGeoInfo(ip net.IP) (*GeoInfo, error) {
 	s.mu.RLock()
 	defer s.mu.RUnlock()
@@ -92,7 +102,7 @@ func (s *MaxMindGeoIPService) GetGeoInfo(ip net.IP) (*GeoInfo, error) {
 		return nil, fmt.Errorf("IP address cannot be nil")
 	}
 
-	var record GeoIpRecord
+	var record Record
 	if err := s.maxMindDBReader.Lookup(ip, &record); err != nil {
 		return nil, fmt.Errorf("error looking up IP %s in MaxMind database: %w", ip.String(), err)
 	}
@@ -108,36 +118,42 @@ func (s *MaxMindGeoIPService) GetGeoInfo(ip net.IP) (*GeoInfo, error) {
 	return geoInfo, nil
 }
 
+// UpdateDatabase downloads the latest MaxMind database and reloads the reader.
 func (s *MaxMindGeoIPService) UpdateDatabase() error {
-	if err := DownloadMaxMindDatabase(s.dbFilePath, GeoIpUrl); err != nil {
+	if err := DownloadMaxMindDatabase(context.Background(), s.dbFilePath, GeoIPURL); err != nil {
 		return err
 	}
 	return s.initialize()
 }
 
-func DownloadMaxMindDatabase(dbFilePath string, downloadURL string) error {
+// DownloadMaxMindDatabase downloads the MaxMind database from downloadURL to dbFilePath.
+func DownloadMaxMindDatabase(ctx context.Context, dbFilePath string, downloadURL string) error {
 	if dbFilePath == "" {
-		dbFilePath = GeoIpFilePath
+		dbFilePath = GeoIPFilePath
 	}
 	if downloadURL == "" {
-		downloadURL = GeoIpUrl
+		downloadURL = GeoIPURL
 	}
-	resp, err := http.Get(downloadURL)
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, downloadURL, nil) //nolint:gosec // URL from trusted GeoIP provider config
 	if err != nil {
 		return fmt.Errorf("failed to initiate MaxMind database download: %w", err)
 	}
-	defer resp.Body.Close()
+	resp, err := http.DefaultClient.Do(req)
+	if err != nil {
+		return fmt.Errorf("failed to initiate MaxMind database download: %w", err)
+	}
+	defer func() { _ = resp.Body.Close() }()
 
 	if resp.StatusCode != http.StatusOK {
 		return fmt.Errorf("failed to download MaxMind database: HTTP status %s", resp.Status)
 	}
 
-	if err := os.MkdirAll(filepath.Dir(dbFilePath), os.ModePerm); err != nil {
+	if err := os.MkdirAll(filepath.Dir(dbFilePath), geoipDataDirPerm); err != nil {
 		return fmt.Errorf("failed to create data directory for MaxMind database update: %w", err)
 	}
 
 	tempPath := dbFilePath + ".download"
-	out, err := os.Create(tempPath)
+	out, err := os.Create(tempPath) //nolint:gosec // tempPath is derived from configured dbFilePath
 	if err != nil {
 		return fmt.Errorf("failed to create MaxMind database file at %s: %w", tempPath, err)
 	}
@@ -157,6 +173,7 @@ func DownloadMaxMindDatabase(dbFilePath string, downloadURL string) error {
 	return nil
 }
 
+// Close closes the MaxMind database reader.
 func (s *MaxMindGeoIPService) Close() error {
 	s.mu.Lock()
 	defer s.mu.Unlock()