代码质量优化

internal/util/cap/cap.go

@@ -36,7 +36,7 @@ type ChallengeConfig struct {
 	Count      int           // Number of puzzles (c)
 	Size       int           // Salt length (s)
 	Difficulty int           // Difficulty prefix length (d)
-	ExpiresMs  time.Duration // Challenge TTL
+	Expires    time.Duration // Challenge TTL
 }
 
 // ChallengeResponse is returned to the client
@@ -156,12 +156,12 @@ func GenerateChallenge(secret []byte, conf ChallengeConfig, scope string) (*Chal
 	if conf.Difficulty <= 0 {
 		conf.Difficulty = 4
 	}
-	if conf.ExpiresMs <= 0 {
-		conf.ExpiresMs = 10 * time.Minute
+	if conf.Expires <= 0 {
+		conf.Expires = 10 * time.Minute
 	}
 
 	now := time.Now().UnixNano() / int64(time.Millisecond)
-	expires := now + int64(conf.ExpiresMs/time.Millisecond)
+	expires := now + int64(conf.Expires/time.Millisecond)
 
 	payload := ChallengePayload{
 		Nonce:      randomHex(25),

internal/util/cap/manager.go

@@ -75,7 +75,7 @@ func (m *Manager) Generate(ctx context.Context, scope string) (*ChallengeRespons
 		Count:      m.getChallengeCount(ctx),
 		Size:       m.getChallengeSize(ctx),
 		Difficulty: m.getChallengeDifficulty(ctx),
-		ExpiresMs:  m.getChallengeTTL(ctx),
+		Expires:    m.getChallengeTTL(ctx),
 	}
 	return GenerateChallenge(m.conf.Secret, c, scope)
 }
@@ -190,14 +190,6 @@ func (m *Manager) VerifyToken(ctx context.Context, token string, expectedScope s
 	return true, nil
 }
 
-// sGet safely calls store.Get, treating a nil store as a miss.
-func sGet(ctx context.Context, store Store, key string) (string, bool, error) {
-	if store == nil {
-		return "", false, nil
-	}
-	return store.Get(ctx, key)
-}
-
 // sGetAndDelete safely calls store.GetAndDelete, treating a nil store as a miss.
 func sGetAndDelete(ctx context.Context, store Store, key string) (string, bool, error) {
 	if store == nil {

internal/util/cap/prng.go

@@ -41,11 +41,6 @@ func fnv1aResume(state uint32, str string) uint32 {
 	return h
 }
 
-// prng generates a hex string of specified length using a seed
-func prng(seed string, length int) string {
-	return prngFromHash(fnv1a(seed), length)
-}
-
 // prngFromHash generates a hex string of specified length using an initial hash state
 func prngFromHash(initialHash uint32, length int) string {
 	state := initialHash