后台 goroutine panic 防护:新增 pkg/util.Go 共享助手(recover+调用点日志),全仓 22 个裸 go func() 站点统一收口

Result: {"status":"keep","total_issues":8,"eslint_errors":0,"eslint_problems":0,"eslint_warnings":0,"golint_canonicalheader":0,"golint_errname":0,"golint_errorlint":1,"golint_exhaustive":0,"golint_forcetypeassert":0,"golint_gosec":0,"golint_intrange":0,"golint_modernize":3,"golint_nilnil":3,"golint_perfsprint":0,"golint_prealloc":0,"golint_recvcheck":1,"golint_test_testifylint":0,"golint_test_thelper":0,"golint_test_total":0,"golint_test_usetesting":0,"golint_total":8,"golint_usestdlibvars":0,"golint_vetx_total":0,"golint_wastedassign":0,"measure_s":112,"tsc_errors":0,"vitest_failed":0,"vitest_total":126}
This commit is contained in:
ryan
2026-08-26 11:06:23 +08:00
parent 3528323b50
commit 55db1c01ec
22 changed files with 137 additions and 54 deletions
+4 -2
View File
@@ -10,6 +10,8 @@ import (
"net"
"net/smtp"
"strings"
"github.com/Rain-kl/Wavelet/pkg/util"
)
func init() {
@@ -86,9 +88,9 @@ func (p *EmailPusher) Send(ctx context.Context, cfg Config, target string, body
// 异步超时处理
errChan := make(chan error, 1)
go func() {
util.Go(func() {
errChan <- smtp.SendMail(host+":"+port, auth, from, []string{to}, msg)
}()
})
select {
case <-ctx.Done():
+31
View File
@@ -0,0 +1,31 @@
// Copyright 2026 Arctel.net
// SPDX-License-Identifier: Apache-2.0
package util
import (
"log/slog"
"runtime"
"runtime/debug"
)
// Go runs fn in a new goroutine and recovers panics, so a background task
// cannot crash the whole process. The panic is logged together with the
// util.Go call site. Use it for every fire-and-forget / long-lived
// background goroutine; HTTP handlers are already covered by gin.Recovery.
func Go(fn func()) {
pc, file, line, _ := runtime.Caller(1)
go func() {
defer func() {
if r := recover(); r != nil {
slog.Error("panic recovered in background goroutine",
"caller", runtime.FuncForPC(pc).Name(),
"file", file,
"line", line,
"panic", r,
"stack", string(debug.Stack()))
}
}()
fn()
}()
}
+31
View File
@@ -0,0 +1,31 @@
// Copyright 2026 Arctel.net
// SPDX-License-Identifier: Apache-2.0
package util
import (
"testing"
"time"
)
func TestGoRunsFn(t *testing.T) {
done := make(chan struct{})
Go(func() { close(done) })
select {
case <-done:
case <-time.After(time.Second):
t.Fatal("fn was not run")
}
}
func TestGoRecoversPanic(t *testing.T) {
done := make(chan struct{})
Go(func() {
defer close(done)
panic("boom")
})
<-done
// Give the recovering goroutine a moment to finish logging; the test
// only fails if the panic had propagated and crashed the process.
time.Sleep(10 * time.Millisecond)
}
+3 -2
View File
@@ -16,6 +16,7 @@ import (
"sync"
"time"
"github.com/Rain-kl/Wavelet/pkg/util"
"golang.org/x/net/websocket"
)
@@ -198,13 +199,13 @@ func (conn *Connection) RunReceiveLoop(ctx context.Context, handler MessageHandl
doneChan := make(chan struct{})
defer close(doneChan)
go func() {
util.Go(func() {
select {
case <-ctx.Done():
_ = conn.Close()
case <-doneChan:
}
}()
})
if err := handler.OnConnect(ctx); err != nil {
handler.OnClose(err)