测试代码质量 25→0：assert↔require 一致性（fail-fast）、float 精确比较→InDelta、Equal("",x)→Empty、Equal(len)→Len、errors.Is/As→ErrorIs/ErrorAs、JSON 字符串→JSONEq、handler goroutine 内 require→assert（真健壮性修复）、t.Helper()、os.MkdirTemp→t.TempDir()（符合 repo AGENTS 约束）。

Result: {"status":"keep","total_issues":8,"golint_canonicalheader":0,"golint_errname":0,"golint_errorlint":1,"golint_forcetypeassert":0,"golint_gosec":0,"golint_intrange":0,"golint_modernize":3,"golint_nilnil":3,"golint_perfsprint":0,"golint_prealloc":0,"golint_recvcheck":1,"golint_usestdlibvars":0,"golint_wastedassign":0,"golint_total":8,"golint_test_testifylint":0,"golint_test_thelper":0,"golint_test_usetesting":0,"golint_test_total":0,"eslint_problems":0,"eslint_errors":0,"eslint_warnings":0,"tsc_errors":0,"measure_s":39}

internal/repository/analytics/node_access_log_test.go

@@ -50,8 +50,8 @@ func TestBatchInsertNodeAccessLogs_UsesModelBatchSQL(t *testing.T) {
 	require.Len(t, mockBatch.rows, 1)
 	assert.Equal(t, "node-a", mockBatch.rows[0][1])
 	require.Len(t, mockBatch.rows[0], 14)
-	assert.Equal(t, "", mockBatch.rows[0][7])            // user_agent
-	assert.Equal(t, "", mockBatch.rows[0][8])            // cache_status
+	assert.Empty(t, mockBatch.rows[0][7])                // user_agent
+	assert.Empty(t, mockBatch.rows[0][8])                // cache_status
 	assert.Equal(t, uint64(2048), mockBatch.rows[0][10]) // bytes_sent
 	assert.Equal(t, uint64(0), mockBatch.rows[0][11])    // request_length
 	assert.Equal(t, uint32(0), mockBatch.rows[0][12])    // request_time_ms

internal/repository/analytics/node_observability_latest_test.go

@@ -55,8 +55,8 @@ func TestListNodeMetricHourly_PrefersRollup(t *testing.T) {
 	rows, err := ListNodeMetricHourly(ctx, NodeObservabilityFilter{Since: since})
 	require.NoError(t, err)
 	require.Len(t, rows, 1)
-	assert.Equal(t, 42.5, rows[0].AverageCPUUsagePercent)
-	assert.Equal(t, 60.0, rows[0].AverageMemoryUsagePercent)
+	assert.InDelta(t, 42.5, rows[0].AverageCPUUsagePercent, 1e-9)
+	assert.InDelta(t, 60.0, rows[0].AverageMemoryUsagePercent, 1e-9)
 	assert.Equal(t, int64(100), rows[0].NetworkRxBytes)
 	assert.Equal(t, 2, rows[0].ReportedNodes)
 	require.Len(t, mock.queries, 1)
@@ -92,10 +92,10 @@ func TestListNodeMetricHourly_MergesRawGapsWithPartialRollup(t *testing.T) {
 	require.NoError(t, err)
 	require.Len(t, rows, 2)
 	assert.Equal(t, rawHour, rows[0].Hour)
-	assert.Equal(t, 12.0, rows[0].AverageCPUUsagePercent)
+	assert.InDelta(t, 12.0, rows[0].AverageCPUUsagePercent, 1e-9)
 	// Overlapping hour prefers rollup (99) over raw (50).
 	assert.Equal(t, rollupHour, rows[1].Hour)
-	assert.Equal(t, 99.0, rows[1].AverageCPUUsagePercent)
+	assert.InDelta(t, 99.0, rows[1].AverageCPUUsagePercent, 1e-9)
 	require.GreaterOrEqual(t, len(mock.queries), 2)
 	assert.Contains(t, mock.queries[1], "lagInFrame")
 }
@@ -112,9 +112,9 @@ func TestMergeNodeMetricHourlyPreferRollup(t *testing.T) {
 	)
 	require.Len(t, merged, 2)
 	assert.Equal(t, h1, merged[0].Hour)
-	assert.Equal(t, 10.0, merged[0].AverageCPUUsagePercent)
+	assert.InDelta(t, 10.0, merged[0].AverageCPUUsagePercent, 1e-9)
 	assert.Equal(t, h2, merged[1].Hour)
-	assert.Equal(t, 80.0, merged[1].AverageCPUUsagePercent)
+	assert.InDelta(t, 80.0, merged[1].AverageCPUUsagePercent, 1e-9)
 }
 
 func TestHourlyRollupCoversWindow(t *testing.T) {
@@ -147,7 +147,7 @@ func TestListNodeMetricHourly_FallsBackToRawOnRollupError(t *testing.T) {
 	rows, err := ListNodeMetricHourly(ctx, NodeObservabilityFilter{})
 	require.NoError(t, err)
 	require.Len(t, rows, 1)
-	assert.Equal(t, 10.0, rows[0].AverageCPUUsagePercent)
+	assert.InDelta(t, 10.0, rows[0].AverageCPUUsagePercent, 1e-9)
 	assert.Equal(t, int64(3), rows[0].DiskReadBytes)
 	require.GreaterOrEqual(t, len(mock.queries), 2)
 	assert.Contains(t, mock.queries[0], nodeMetricCapacityHourlyTableName())

internal/repository/task_execution_test.go

@@ -23,6 +23,7 @@ import (
 )
 
 func setupTaskExecutionTestEnvironment(t *testing.T) func() {
+	t.Helper()
 	sqliteDB, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{
 		DisableForeignKeyConstraintWhenMigrating: true,
 	})
@@ -323,7 +324,7 @@ func TestAppendTaskExecutionLogNonExistent(t *testing.T) {
 
 	// Redis 缓冲不依赖数据库记录是否已经创建。
 	err := AppendTaskExecutionLog(ctx, "nonexistent_task", "测试日志")
-	assert.NoError(t, err)
+	require.NoError(t, err)
 
 	err = FlushTaskExecutionLog(ctx, "nonexistent_task")
 	assert.Error(t, err)
@@ -454,7 +455,7 @@ func TestListTaskExecutionsDefaultPaging(t *testing.T) {
 	items, total, err := ListTaskExecutions(ctx, model.ListTaskExecutionsRequest{})
 	require.NoError(t, err)
 	assert.Equal(t, int64(0), total)
-	assert.Len(t, items, 0)
+	assert.Empty(t, items)
 }
 
 func TestCleanupTaskExecutionLogs(t *testing.T) {