测试代码质量 25→0:assert↔require 一致性(fail-fast)、float 精确比较→InDelta、Equal("",x)→Empty、Equal(len)→Len、errors.Is/As→ErrorIs/ErrorAs、JSON 字符串→JSONEq、handler goroutine 内 require→assert(真健壮性修复)、t.Helper()、os.MkdirTemp→t.TempDir()(符合 repo AGENTS 约束)。

Result: {"status":"keep","total_issues":8,"golint_canonicalheader":0,"golint_errname":0,"golint_errorlint":1,"golint_forcetypeassert":0,"golint_gosec":0,"golint_intrange":0,"golint_modernize":3,"golint_nilnil":3,"golint_perfsprint":0,"golint_prealloc":0,"golint_recvcheck":1,"golint_usestdlibvars":0,"golint_wastedassign":0,"golint_total":8,"golint_test_testifylint":0,"golint_test_thelper":0,"golint_test_usetesting":0,"golint_test_total":0,"eslint_problems":0,"eslint_errors":0,"eslint_warnings":0,"tsc_errors":0,"measure_s":39}
This commit is contained in:
ryan
2026-08-16 18:12:58 +08:00
parent e5f6b0ad90
commit 63a24da9ee
32 changed files with 113 additions and 95 deletions
+1 -1
View File
@@ -82,7 +82,7 @@ func TestCustomPusherSend_ResponseBodyErrcode(t *testing.T) {
assert.Contains(t, err.Error(), tt.wantErrMsg)
return
}
assert.NoError(t, err)
require.NoError(t, err)
if tt.body != "" {
assert.Contains(t, upstreamResp, tt.body)
}
+5 -5
View File
@@ -23,7 +23,7 @@ func TestTelegramPusher_Send(t *testing.T) {
assert.Equal(t, "application/json", r.Header.Get("Content-Type"))
err := json.NewDecoder(r.Body).Decode(&receivedReq)
require.NoError(t, err)
assert.NoError(t, err)
w.WriteHeader(http.StatusOK)
_, _ = w.Write([]byte(`{"ok": true}`))
@@ -55,7 +55,7 @@ func TestTelegramPusher_Send(t *testing.T) {
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
var req telegramMessageRequest
err := json.NewDecoder(r.Body).Decode(&req)
require.NoError(t, err)
assert.NoError(t, err)
requests = append(requests, &req)
if len(requests) == 1 {
@@ -84,7 +84,7 @@ func TestTelegramPusher_Send(t *testing.T) {
require.Len(t, requests, 2)
assert.Equal(t, "HTML", requests[0].ParseMode)
assert.Equal(t, "", requests[1].ParseMode)
assert.Empty(t, requests[1].ParseMode)
assert.Contains(t, requests[1].Text, "[INFO] Alert & Info")
assert.Contains(t, requests[1].Text, "A < B comparison")
})
@@ -96,7 +96,7 @@ func TestTelegramPusher_Send(t *testing.T) {
URL: "https://api.telegram.org",
}
err := pusher.ValidateConfig(cfg)
assert.Error(t, err)
require.Error(t, err)
cfg = Config{
Channel: "telegram",
@@ -104,7 +104,7 @@ func TestTelegramPusher_Send(t *testing.T) {
Secret: "token",
}
err = pusher.ValidateConfig(cfg)
assert.Error(t, err)
require.Error(t, err)
cfg = Config{
Channel: "telegram",