重构

internal/apps/admin/system_config/routers.go

@@ -227,52 +227,6 @@ func UpdateSystemConfig(c *gin.Context) {
 	c.JSON(http.StatusOK, util.OKNil())
 }
 
-// DeleteSystemConfig 删除系统配置
-// @Summary 删除系统配置
-// @Description 根据配置键删除对应配置，同时从 Redis 中移除对应缓存，需要管理员权限
-// @Tags admin
-// @Produce json
-// @Security SessionCookie
-// @Param key path string true "配置键"
-// @Success 200 {object} util.ResponseAny{data=string} "删除成功"
-// @Failure 401 {object} util.ResponseAny "未登录"
-// @Failure 403 {object} util.ResponseAny "无管理员权限"
-// @Failure 404 {object} util.ResponseAny "配置不存在"
-// @Failure 500 {object} util.ResponseAny "内部错误"
-// @Router /api/v1/admin/system-configs/{key} [delete]
-func DeleteSystemConfig(c *gin.Context) {
-	key := c.Param("key")
-
-	// 检查配置是否存在
-	var config model.SystemConfig
-	if err := db.DB(c.Request.Context()).Where("key = ?", key).First(&config).Error; err != nil {
-		if errors.Is(err, gorm.ErrRecordNotFound) {
-			c.JSON(http.StatusNotFound, util.Err(SystemConfigNotFound))
-		} else {
-			c.JSON(http.StatusInternalServerError, util.Err(err.Error()))
-		}
-		return
-	}
-
-	if err := db.DB(c.Request.Context()).Transaction(func(tx *gorm.DB) error {
-		// 删除配置
-		if err := tx.Delete(&config).Error; err != nil {
-			return err
-		}
-
-		if err := db.Redis.HDel(c.Request.Context(), db.PrefixedKey(model.SystemConfigRedisHashKey), key).Err(); err != nil {
-			return err
-		}
-
-		return nil
-	}); err != nil {
-		c.JSON(http.StatusInternalServerError, util.Err(err.Error()))
-		return
-	}
-
-	c.JSON(http.StatusOK, util.OKNil())
-}
-
 // TestSMTPRequest 测试 SMTP 配置请求
 type TestSMTPRequest struct {
 	SMTPHost     string `json:"smtp_host" binding:"required,max=255"`

internal/apps/admin/system_config/routers_test.go

@@ -56,7 +56,6 @@ func setupTestRouter(authUser *model.User) *gin.Engine {
 	{
 		systemConfigRouter.GET("", GetSystemConfig)
 		systemConfigRouter.PUT("", UpdateSystemConfig)
-		systemConfigRouter.DELETE("", DeleteSystemConfig)
 	}
 
 	return r
@@ -263,48 +262,6 @@ func TestUpdateSystemConfig(t *testing.T) {
 	})
 }
 
-func TestDeleteSystemConfig(t *testing.T) {
-	dbConn, _, cleanup := testhelper.SetupTestEnvironment(t)
-	defer cleanup()
-
-	adminUser := &model.User{ID: 1001, Username: "admin", IsAdmin: true}
-	router := setupTestRouter(adminUser)
-
-	t.Run("delete successfully", func(t *testing.T) {
-		req, _ := http.NewRequest("DELETE", "/api/v1/admin/system-configs/"+model.ConfigKeySiteName, nil)
-		w := httptest.NewRecorder()
-		router.ServeHTTP(w, req)
-
-		if w.Code != http.StatusOK {
-			t.Fatalf("expected 200 OK, got %d. Body: %s", w.Code, w.Body.String())
-		}
-
-		// Verify database
-		var count int64
-		dbConn.Model(&model.SystemConfig{}).Where("key = ?", model.ConfigKeySiteName).Count(&count)
-		if count != 0 {
-			t.Error("config still exists in DB")
-		}
-
-		// Verify Redis Cache removal
-		var redisConfig model.SystemConfig
-		err := db.HGetJSON(context.Background(), model.SystemConfigRedisHashKey, model.ConfigKeySiteName, &redisConfig)
-		if err == nil {
-			t.Error("config should have been deleted from Redis cache")
-		}
-	})
-
-	t.Run("delete non-existent config", func(t *testing.T) {
-		req, _ := http.NewRequest("DELETE", "/api/v1/admin/system-configs/invalid_key", nil)
-		w := httptest.NewRecorder()
-		router.ServeHTTP(w, req)
-
-		if w.Code != http.StatusNotFound {
-			t.Errorf("expected 404 Not Found, got %d", w.Code)
-		}
-	})
-}
-
 func TestTestSMTP(t *testing.T) {
 	_, _, cleanup := testhelper.SetupTestEnvironment(t)
 	defer cleanup()