重构

internal/storage/errs.go

@@ -1,6 +1,5 @@
 /*
-Copyright 2025 linux.do
-Modified by Arctel.net, 2026
+Copyright 2026 Arctel.net
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -20,11 +19,21 @@ package storage
 type ErrS3InitializationFailed struct{}
 
 func (e ErrS3InitializationFailed) Error() string {
-	return "S3存储初始化失败"
+	return errS3InitializationFailed
 }
 
 type LocalCacheError struct{}
 
 func (e LocalCacheError) Error() string {
-	return "本地缓存错误"
+	return errLocalCache
 }
+
+const (
+	errS3InitializationFailed = "S3存储初始化失败"
+	errLocalCache             = "本地缓存错误"
+	errS3PutObjectFailed      = "s3 put object failed: %w"
+	errS3GetObjectFailed      = "s3 get object failed: %w"
+	errCDNRequestFailed       = "cdn request failed: %w"
+	errCDNStatusFailed        = "cdn returned status %d"
+	errS3DeleteObjectFailed   = "s3 delete object failed: %w"
+)

internal/storage/s3.go

@@ -146,7 +146,7 @@ func putObjectDefault(ctx context.Context, key string, body io.Reader, size int6
 	_, err := client.PutObject(ctx, input)
 	if err != nil {
 		span.SetStatus(codes.Error, fmt.Sprintf("S3 put object failed: %v", err))
-		return fmt.Errorf("s3 put object failed: %w", err)
+		return fmt.Errorf(errS3PutObjectFailed, err)
 	}
 	return nil
 }
@@ -181,7 +181,7 @@ func getObjectDefault(ctx context.Context, key string) (*ObjectInfo, error) {
 	})
 	if err != nil {
 		span.SetStatus(codes.Error, fmt.Sprintf("S3 get object failed: %v", err))
-		return nil, fmt.Errorf("s3 get object failed: %w", err)
+		return nil, fmt.Errorf(errS3GetObjectFailed, err)
 	}
 
 	contentType := "application/octet-stream"
@@ -223,13 +223,13 @@ func GetObjectViaProxy(ctx context.Context, key string) (*ObjectInfo, error) {
 	resp, err := util.Request(ctx, http.MethodGet, url, nil, nil, nil)
 	if err != nil {
 		span.SetStatus(codes.Error, fmt.Sprintf("cdn request failed: %v", err))
-		return nil, fmt.Errorf("cdn request failed: %w", err)
+		return nil, fmt.Errorf(errCDNRequestFailed, err)
 	}
 
 	if resp.StatusCode != http.StatusOK {
 		resp.Body.Close()
 		span.SetStatus(codes.Error, fmt.Sprintf("cdn returned status %d", resp.StatusCode))
-		return nil, fmt.Errorf("cdn returned status %d", resp.StatusCode)
+		return nil, fmt.Errorf(errCDNStatusFailed, resp.StatusCode)
 	}
 
 	contentType := resp.Header.Get("Content-Type")
@@ -265,7 +265,7 @@ func deleteObjectDefault(ctx context.Context, key string) error {
 	})
 	if err != nil {
 		span.SetStatus(codes.Error, fmt.Sprintf("S3 delete object failed: %v", err))
-		return fmt.Errorf("s3 delete object failed: %w", err)
+		return fmt.Errorf(errS3DeleteObjectFailed, err)
 	}
 	return nil
 }