[优化] 重构 API 处理逻辑,简化参数解析和响应处理

This commit is contained in:
ryan
2026-05-31 13:31:32 +08:00
parent bcd669722e
commit ec70794577
11 changed files with 183 additions and 547 deletions
+19 -74
View File
@@ -1,11 +1,8 @@
package controller
import (
"encoding/json"
"github.com/gin-gonic/gin"
"net/http"
"openflare/model"
"strconv"
)
type DnsAccountInput struct {
@@ -24,17 +21,10 @@ type DnsAccountInput struct {
func GetDnsAccounts(c *gin.Context) {
accounts, err := model.ListDnsAccounts()
if err != nil {
c.JSON(http.StatusOK, gin.H{
"success": false,
"message": err.Error(),
})
respondFailure(c, err.Error())
return
}
c.JSON(http.StatusOK, gin.H{
"success": true,
"message": "",
"data": accounts,
})
respondSuccess(c, accounts)
}
// CreateDnsAccount godoc
@@ -48,11 +38,7 @@ func GetDnsAccounts(c *gin.Context) {
// @Router /api/dns-accounts/ [post]
func CreateDnsAccount(c *gin.Context) {
var input DnsAccountInput
if err := json.NewDecoder(c.Request.Body).Decode(&input); err != nil {
c.JSON(http.StatusBadRequest, gin.H{
"success": false,
"message": "无效的参数",
})
if !bindJSON(c, &input) {
return
}
@@ -63,18 +49,11 @@ func CreateDnsAccount(c *gin.Context) {
}
if err := account.Insert(); err != nil {
c.JSON(http.StatusOK, gin.H{
"success": false,
"message": err.Error(),
})
respondFailure(c, err.Error())
return
}
c.JSON(http.StatusOK, gin.H{
"success": true,
"message": "",
"data": account,
})
respondSuccess(c, account)
}
// UpdateDnsAccount godoc
@@ -88,30 +67,19 @@ func CreateDnsAccount(c *gin.Context) {
// @Success 200 {object} map[string]interface{}
// @Router /api/dns-accounts/{id}/update [post]
func UpdateDnsAccount(c *gin.Context) {
id, err := strconv.ParseUint(c.Param("id"), 10, 64)
if err != nil || id == 0 {
c.JSON(http.StatusBadRequest, gin.H{
"success": false,
"message": "无效的参数",
})
id, ok := parseIDParam(c)
if !ok {
return
}
var input DnsAccountInput
if err := json.NewDecoder(c.Request.Body).Decode(&input); err != nil {
c.JSON(http.StatusBadRequest, gin.H{
"success": false,
"message": "无效的参数",
})
if !bindJSON(c, &input) {
return
}
account, err := model.GetDnsAccountByID(uint(id))
account, err := model.GetDnsAccountByID(id)
if err != nil {
c.JSON(http.StatusOK, gin.H{
"success": false,
"message": err.Error(),
})
respondFailure(c, err.Error())
return
}
@@ -120,18 +88,11 @@ func UpdateDnsAccount(c *gin.Context) {
account.Authorization = input.Authorization
if err := account.Update(); err != nil {
c.JSON(http.StatusOK, gin.H{
"success": false,
"message": err.Error(),
})
respondFailure(c, err.Error())
return
}
c.JSON(http.StatusOK, gin.H{
"success": true,
"message": "",
"data": account,
})
respondSuccess(c, account)
}
// DeleteDnsAccount godoc
@@ -143,21 +104,14 @@ func UpdateDnsAccount(c *gin.Context) {
// @Success 200 {object} map[string]interface{}
// @Router /api/dns-accounts/{id}/delete [post]
func DeleteDnsAccount(c *gin.Context) {
id, err := strconv.ParseUint(c.Param("id"), 10, 64)
if err != nil || id == 0 {
c.JSON(http.StatusBadRequest, gin.H{
"success": false,
"message": "无效的参数",
})
id, ok := parseIDParam(c)
if !ok {
return
}
account, err := model.GetDnsAccountByID(uint(id))
account, err := model.GetDnsAccountByID(id)
if err != nil {
c.JSON(http.StatusOK, gin.H{
"success": false,
"message": err.Error(),
})
respondFailure(c, err.Error())
return
}
@@ -165,23 +119,14 @@ func DeleteDnsAccount(c *gin.Context) {
var count int64
model.DB.Model(&model.TLSCertificate{}).Where("dns_account_id = ?", id).Count(&count)
if count > 0 {
c.JSON(http.StatusOK, gin.H{
"success": false,
"message": "该 DNS 账号已被证书使用,无法删除",
})
respondFailure(c, "该 DNS 账号已被证书使用,无法删除")
return
}
if err := account.Delete(); err != nil {
c.JSON(http.StatusOK, gin.H{
"success": false,
"message": err.Error(),
})
respondFailure(c, err.Error())
return
}
c.JSON(http.StatusOK, gin.H{
"success": true,
"message": "",
})
respondSuccess(c, nil)
}