OpenFlare/openflare_agent/internal/observability/traffic_test.go

package observability

import (
	"os"
	"path/filepath"
	"testing"

	"openflare-agent/internal/config"
	"openflare-agent/internal/protocol"
	"openflare-agent/internal/state"
)

func TestBuildTrafficReportAggregatesManagedAccessLog(t *testing.T) {
	tempDir := t.TempDir()
	routeConfigPath := filepath.Join(tempDir, "conf.d", "openflare_routes.conf")
	if err := os.MkdirAll(filepath.Dir(routeConfigPath), 0o755); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}
	logPath := filepath.Join(filepath.Dir(routeConfigPath), "openflare_access.log")
	content := []byte(
		"{\"ts\":\"2026-03-14T08:00:00Z\",\"host\":\"app.example.com\",\"path\":\"/\",\"remote_addr\":\"10.0.0.1\",\"status\":200}\n" +
			"{\"ts\":\"2026-03-14T08:00:05Z\",\"host\":\"app.example.com\",\"path\":\"/healthz\",\"remote_addr\":\"10.0.0.2\",\"status\":503}\n" +
			"{\"ts\":\"2026-03-14T08:00:08Z\",\"host\":\"api.example.com\",\"path\":\"/api\",\"remote_addr\":\"10.0.0.1\",\"status\":200}\n",
	)
	if err := os.WriteFile(logPath, content, 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}

	stateStore := state.NewStore(filepath.Join(tempDir, "state.json"))
	report := BuildTrafficReport(&config.Config{RouteConfigPath: routeConfigPath}, stateStore, nil)
	if report == nil {
		t.Fatal("expected traffic report")
	}
	if report.RequestCount != 3 || report.ErrorCount != 1 || report.UniqueVisitorCount != 2 {
		t.Fatalf("unexpected traffic report counters: %+v", report)
	}
	if report.StatusCodes["200"] != 2 || report.StatusCodes["503"] != 1 {
		t.Fatalf("unexpected status codes: %+v", report.StatusCodes)
	}
	if report.TopDomains["app.example.com"] != 2 || report.TopDomains["api.example.com"] != 1 {
		t.Fatalf("unexpected top domains: %+v", report.TopDomains)
	}

	snapshot, err := stateStore.Load()
	if err != nil {
		t.Fatalf("Load failed: %v", err)
	}
	if snapshot.AccessLogOffset != int64(len(content)) {
		t.Fatalf("unexpected access log offset: %d", snapshot.AccessLogOffset)
	}

	secondReport := BuildTrafficReport(&config.Config{RouteConfigPath: routeConfigPath}, stateStore, nil)
	if secondReport != nil {
		t.Fatalf("expected no report without appended lines, got %+v", secondReport)
	}
}

func TestBuildTrafficReportResetsOffsetAfterTruncate(t *testing.T) {
	tempDir := t.TempDir()
	routeConfigPath := filepath.Join(tempDir, "conf.d", "openflare_routes.conf")
	if err := os.MkdirAll(filepath.Dir(routeConfigPath), 0o755); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}
	logPath := filepath.Join(filepath.Dir(routeConfigPath), "openflare_access.log")
	if err := os.WriteFile(logPath, []byte("{\"ts\":\"2026-03-14T09:00:00Z\",\"host\":\"app.example.com\",\"path\":\"/\",\"remote_addr\":\"10.0.0.3\",\"status\":200}\n"), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}

	stateStore := state.NewStore(filepath.Join(tempDir, "state.json"))
	if err := stateStore.Save(&state.Snapshot{AccessLogOffset: 4096}); err != nil {
		t.Fatalf("Save failed: %v", err)
	}

	report := BuildTrafficReport(&config.Config{RouteConfigPath: routeConfigPath}, stateStore, nil)
	if report == nil || report.RequestCount != 1 {
		t.Fatalf("expected one request after truncate reset, got %+v", report)
	}
}

func TestBuildTrafficObservabilityReturnsAccessLogs(t *testing.T) {
	tempDir := t.TempDir()
	routeConfigPath := filepath.Join(tempDir, "conf.d", "openflare_routes.conf")
	if err := os.MkdirAll(filepath.Dir(routeConfigPath), 0o755); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}
	logPath := filepath.Join(filepath.Dir(routeConfigPath), "openflare_access.log")
	content := []byte(
		"{\"ts\":\"2026-03-14T08:00:00Z\",\"host\":\"app.example.com\",\"path\":\"/login\",\"remote_addr\":\"10.0.0.1\",\"status\":200,\"request_length\":128,\"bytes_sent\":512}\n" +
			"{\"ts\":\"2026-03-14T08:00:05Z\",\"host\":\"api.example.com\",\"path\":\"/v1/ping\",\"remote_addr\":\"10.0.0.2\",\"status\":502,\"request_length\":64,\"bytes_sent\":256}\n",
	)
	if err := os.WriteFile(logPath, content, 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}

	stateStore := state.NewStore(filepath.Join(tempDir, "state.json"))
	report, accessLogs, fallbackMetrics := BuildTrafficObservability(&config.Config{RouteConfigPath: routeConfigPath}, stateStore, nil)
	if report == nil || report.RequestCount != 2 {
		t.Fatalf("expected traffic report, got %+v", report)
	}
	if len(accessLogs) != 2 {
		t.Fatalf("expected access logs, got %+v", accessLogs)
	}
	if fallbackMetrics == nil || fallbackMetrics.OpenrestyRxBytes != 192 || fallbackMetrics.OpenrestyTxBytes != 768 {
		t.Fatalf("expected fallback throughput metrics, got %+v", fallbackMetrics)
	}
	if accessLogs[0].Path != "/login" || accessLogs[1].Path != "/v1/ping" {
		t.Fatalf("unexpected access log paths: %+v", accessLogs)
	}
}

func TestBuildTrafficReportParsesCombinedAccessLog(t *testing.T) {
	tempDir := t.TempDir()
	routeConfigPath := filepath.Join(tempDir, "conf.d", "openflare_routes.conf")
	if err := os.MkdirAll(filepath.Dir(routeConfigPath), 0o755); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}
	logPath := filepath.Join(filepath.Dir(routeConfigPath), "openflare_access.log")
	content := []byte(
		"10.0.0.1 - - [14/Mar/2026:08:00:00 +0000] \"GET / HTTP/1.1\" 200 123 \"-\" \"curl/8.0\"\n" +
			"10.0.0.2 - - [14/Mar/2026:08:00:05 +0000] \"GET /healthz HTTP/1.1\" 502 64 \"-\" \"curl/8.0\"\n" +
			"10.0.0.1 - - [14/Mar/2026:08:00:10 +0000] \"GET /api HTTP/1.1\" 200 256 \"-\" \"curl/8.0\"\n",
	)
	if err := os.WriteFile(logPath, content, 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}

	stateStore := state.NewStore(filepath.Join(tempDir, "state.json"))
	report := BuildTrafficReport(&config.Config{RouteConfigPath: routeConfigPath}, stateStore, nil)
	if report == nil {
		t.Fatal("expected traffic report from combined access log")
	}
	if report.RequestCount != 3 || report.ErrorCount != 1 || report.UniqueVisitorCount != 2 {
		t.Fatalf("unexpected combined log counters: %+v", report)
	}
	if report.StatusCodes["200"] != 2 || report.StatusCodes["502"] != 1 {
		t.Fatalf("unexpected combined log status codes: %+v", report.StatusCodes)
	}
	if len(report.TopDomains) != 0 {
		t.Fatalf("expected combined access log to omit top domains when host is unavailable, got %+v", report.TopDomains)
	}
}

func TestBuildTrafficReportReturnsManagedWindowEvenWhenRequestCountZero(t *testing.T) {
	report := BuildTrafficReport(nil, nil, &managedOpenRestyMetrics{
		TrafficReport: &protocol.NodeTrafficReport{
			WindowStartedAtUnix: 1710403200,
			WindowEndedAtUnix:   1710403260,
			RequestCount:        0,
			ErrorCount:          0,
			UniqueVisitorCount:  0,
			StatusCodes:         map[string]int64{},
			TopDomains:          map[string]int64{},
			SourceCountries:     map[string]int64{},
		},
	})
	if report == nil {
		t.Fatal("expected managed traffic report to be returned even when request count is zero")
	}
	if report.RequestCount != 0 || report.WindowStartedAtUnix != 1710403200 || report.WindowEndedAtUnix != 1710403260 {
		t.Fatalf("unexpected managed traffic report: %+v", report)
	}
}