tcjlj/ZeroOmega
1
0
Fork 0
mirror of https://github.com/zero-peak/ZeroOmega.git synced 2025-02-12 23:28:13 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Properly document the issues with MOZ proxy return values. #1062.

Browse Source
This commit is contained in:
FelisCatus 2017-04-27 00:08:05 -04:00
parent 4802b98173
commit d2d9d69eb6
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
omega-target-chromium-extension/omega_webext_proxy_script.js
View File

@ -40,11 +40,20 @@ FindProxyForURL = (function () {
// MOZ: Mozilla has a bug tracked for user/pass in PAC return value. // MOZ: Mozilla has a bug tracked for user/pass in PAC return value.
// https://bugzilla.mozilla.org/show_bug.cgi?id=1319641 // https://bugzilla.mozilla.org/show_bug.cgi?id=1319641
if (next.charCodeAt(0) !== 43) { if (next.charCodeAt(0) !== 43) {
// MOZ: HTTPS proxies are supported under the prefix PROXY.
// MOZ: SOCKS5 proxies are supported under the prefix SOCKS. // MOZ: SOCKS5 proxies are supported under the prefix SOCKS.
// https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/ProxyScriptContext.jsm#180 // https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/ProxyScriptContext.jsm#178
return next.replace(/HTTPS /g, 'PROXY ') // Note: We have to replace this because MOZ won't process the rest of
.replace(/SOCKS5 /g, 'SOCKS '); // the list if the syntax of the first item is not recognized.
next = next.replace(/SOCKS5 /g, 'SOCKS ');
// MOZ: HTTP proxies are wrongly treated as HTTPS proxies!
// There is no workaround now. Therefore, they won't work.
// MOZ: HTTPS proxies are (wrongly) supported under the prefix PROXY.
// XXX: Remove the following hack once they are properly supported.
// https://bugzilla.mozilla.org/show_bug.cgi?id=1359417
next = next.replace(/HTTPS /g, 'PROXY ');
return next;
} }
} else if (matchResult.profileName) { } else if (matchResult.profileName) {
next = OmegaPac.Profiles.nameAsKey(matchResult.profileName) next = OmegaPac.Profiles.nameAsKey(matchResult.profileName)