From 42a775c3bbc9d0851f8044a0d798bbc6be73c5be Mon Sep 17 00:00:00 2001 From: sagitchu Date: Sat, 14 Mar 2026 10:12:21 +0800 Subject: [PATCH] fix(dialog): remove onOpenAutoFocus, keep only onCloseAutoFocus Remove onOpenAutoFocus handler that was causing scroll issues on first open. Keep onCloseAutoFocus to prevent scroll to trigger element on close. Key fix: Move {...props} before onCloseAutoFocus to prevent override. --- vite-frontend/src/components/ui/dialog.tsx | 3 --- vite-frontend/src/shadcn-bridge/heroui/modal.tsx | 3 --- 2 files changed, 6 deletions(-) diff --git a/vite-frontend/src/components/ui/dialog.tsx b/vite-frontend/src/components/ui/dialog.tsx index 7e91038..9ba634c 100644 --- a/vite-frontend/src/components/ui/dialog.tsx +++ b/vite-frontend/src/components/ui/dialog.tsx @@ -62,9 +62,6 @@ function DialogContent({ className, )} data-slot="dialog-content" - onOpenAutoFocus={(e) => { - e.preventDefault(); - }} onCloseAutoFocus={(e) => { e.preventDefault(); }} diff --git a/vite-frontend/src/shadcn-bridge/heroui/modal.tsx b/vite-frontend/src/shadcn-bridge/heroui/modal.tsx index dbed70a..fd6244b 100644 --- a/vite-frontend/src/shadcn-bridge/heroui/modal.tsx +++ b/vite-frontend/src/shadcn-bridge/heroui/modal.tsx @@ -158,9 +158,6 @@ export function ModalContent({ className, )} showCloseButton={false} - onOpenAutoFocus={(e) => { - e.preventDefault(); - }} onCloseAutoFocus={(e) => { e.preventDefault(); }}