mirror of
https://github.com/Sagit-chu/flvx.git
synced 2026-09-28 07:36:38 +08:00
feat: add configurable GitHub proxy settings (#401)
* docs: add GitHub proxy config design spec * docs: add GitHub proxy config implementation plan * feat(backend): use configurable github proxy for node upgrades * feat(backend): use configurable github proxy for node install command * feat(frontend): add github proxy config settings * feat(script): support configurable github proxy in installer flows Honor custom GitHub mirror settings across interactive and env-driven installer/update paths so script downloads match the panel configuration. Add shell regressions to lock down proxy prompting, URL recomputation, and non-interactive fallback behavior.
This commit is contained in:
sagit
@@ -0,0 +1,314 @@
|
||||
#!/bin/bash
|
||||
set -euo pipefail
|
||||
|
||||
ROOT_DIR=$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)
|
||||
|
||||
fail() {
|
||||
echo "FAIL: $1" >&2
|
||||
exit 1
|
||||
}
|
||||
|
||||
assert_equals() {
|
||||
local expected="$1"
|
||||
local actual="$2"
|
||||
local message="$3"
|
||||
|
||||
if [[ "$actual" != "$expected" ]]; then
|
||||
fail "$message (expected: $expected, actual: $actual)"
|
||||
fi
|
||||
}
|
||||
|
||||
load_script_without_main() {
|
||||
local script_path="$1"
|
||||
local temp_file
|
||||
|
||||
temp_file=$(mktemp)
|
||||
sed '/^# 执行主函数$/,$d' "$script_path" > "$temp_file"
|
||||
VERSION="v-test"
|
||||
source "$temp_file"
|
||||
rm -f "$temp_file"
|
||||
}
|
||||
|
||||
test_install_script_respects_disabled_proxy() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/install.sh"
|
||||
|
||||
PROXY_ENABLED="false"
|
||||
PROXY_URL=""
|
||||
|
||||
local actual
|
||||
actual=$(maybe_proxy_url "https://github.com/example/release")
|
||||
|
||||
assert_equals \
|
||||
"https://github.com/example/release" \
|
||||
"$actual" \
|
||||
"install.sh should bypass the proxy when disabled"
|
||||
)
|
||||
|
||||
test_install_script_asks_for_proxy_config() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/install.sh"
|
||||
|
||||
PROXY_ENABLED=""
|
||||
PROXY_URL=""
|
||||
|
||||
ask_proxy_config >/dev/null < <(printf '\nmirror.example.com/\n')
|
||||
|
||||
assert_equals "true" "$PROXY_ENABLED" "install.sh should enable proxy by default"
|
||||
assert_equals "mirror.example.com/" "$PROXY_URL" "install.sh should keep the entered proxy URL"
|
||||
|
||||
local actual
|
||||
actual=$(maybe_proxy_url "https://github.com/example/release")
|
||||
|
||||
assert_equals \
|
||||
"https://mirror.example.com/https://github.com/example/release" \
|
||||
"$actual" \
|
||||
"install.sh should normalize the entered proxy URL"
|
||||
)
|
||||
|
||||
test_install_script_recomputes_download_url_after_prompt() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/install.sh"
|
||||
|
||||
PROXY_ENABLED=""
|
||||
PROXY_URL=""
|
||||
DOWNLOAD_URL=""
|
||||
|
||||
ask_proxy_config >/dev/null < <(printf 'n\n')
|
||||
ensure_download_url_initialized
|
||||
|
||||
local expected
|
||||
expected=$(build_download_url)
|
||||
|
||||
assert_equals \
|
||||
"$expected" \
|
||||
"$DOWNLOAD_URL" \
|
||||
"install.sh should build the final download URL after the interactive proxy choice"
|
||||
)
|
||||
|
||||
test_update_flux_agent_asks_for_proxy_config() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/install.sh"
|
||||
|
||||
INSTALL_DIR=$(mktemp -d)
|
||||
cat > "$INSTALL_DIR/flux_agent" <<'EOF'
|
||||
#!/bin/bash
|
||||
echo "old version"
|
||||
EOF
|
||||
chmod +x "$INSTALL_DIR/flux_agent"
|
||||
|
||||
local ask_called="0"
|
||||
|
||||
ask_proxy_config() {
|
||||
ask_called="1"
|
||||
PROXY_ENABLED="false"
|
||||
DOWNLOAD_URL=""
|
||||
}
|
||||
|
||||
check_and_install_tcpkill() { :; }
|
||||
|
||||
systemctl() {
|
||||
return 0
|
||||
}
|
||||
|
||||
curl() {
|
||||
local output=""
|
||||
|
||||
while [[ $# -gt 0 ]]; do
|
||||
if [[ "$1" == "-o" ]]; then
|
||||
output="$2"
|
||||
shift 2
|
||||
continue
|
||||
fi
|
||||
shift
|
||||
done
|
||||
|
||||
cat > "$output" <<'EOF'
|
||||
#!/bin/bash
|
||||
echo "new version"
|
||||
EOF
|
||||
chmod +x "$output"
|
||||
}
|
||||
|
||||
update_flux_agent >/dev/null
|
||||
|
||||
assert_equals "1" "$ask_called" "update_flux_agent should ask for proxy config before downloading"
|
||||
assert_equals "$(build_download_url)" "$DOWNLOAD_URL" "update_flux_agent should honor the prompted proxy choice"
|
||||
)
|
||||
|
||||
test_update_flux_agent_skips_proxy_prompt_when_not_installed() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/install.sh"
|
||||
|
||||
INSTALL_DIR=$(mktemp -u)
|
||||
|
||||
local ask_called="0"
|
||||
|
||||
ask_proxy_config() {
|
||||
ask_called="1"
|
||||
}
|
||||
|
||||
local rc="0"
|
||||
update_flux_agent >/dev/null || rc="$?"
|
||||
|
||||
assert_equals "1" "$rc" "update_flux_agent should fail when the agent is not installed"
|
||||
assert_equals "0" "$ask_called" "update_flux_agent should not prompt for proxy config when the agent is missing"
|
||||
)
|
||||
|
||||
test_install_script_accepts_proxy_url_env_without_prompt() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/install.sh"
|
||||
|
||||
PROXY_ENABLED=""
|
||||
PROXY_URL="mirror.example.com"
|
||||
|
||||
ask_proxy_config >/dev/null < <(printf '\n\n')
|
||||
|
||||
assert_equals "true" "$PROXY_ENABLED" "install.sh should treat PROXY_URL as enabling the proxy"
|
||||
assert_equals "mirror.example.com" "$PROXY_URL" "install.sh should preserve PROXY_URL when provided via env"
|
||||
)
|
||||
|
||||
test_panel_install_script_can_disable_proxy() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/panel_install.sh"
|
||||
|
||||
PROXY_ENABLED=""
|
||||
PROXY_URL=""
|
||||
|
||||
ask_proxy_config >/dev/null < <(printf 'n\n')
|
||||
|
||||
assert_equals "false" "$PROXY_ENABLED" "panel_install.sh should allow disabling proxy"
|
||||
|
||||
local actual
|
||||
actual=$(maybe_proxy_url "https://github.com/example/release")
|
||||
|
||||
assert_equals \
|
||||
"https://github.com/example/release" \
|
||||
"$actual" \
|
||||
"panel_install.sh should bypass the proxy after disabling it"
|
||||
)
|
||||
|
||||
test_panel_install_script_recomputes_compose_urls_after_prompt() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/panel_install.sh"
|
||||
|
||||
PROXY_ENABLED=""
|
||||
PROXY_URL=""
|
||||
DOCKER_COMPOSEV4_URL=""
|
||||
DOCKER_COMPOSEV6_URL=""
|
||||
|
||||
ask_proxy_config >/dev/null < <(printf 'n\n')
|
||||
ensure_compose_urls_initialized
|
||||
|
||||
assert_equals \
|
||||
"https://github.com/${REPO}/releases/download/${RESOLVED_VERSION}/docker-compose-v4.yml" \
|
||||
"$DOCKER_COMPOSEV4_URL" \
|
||||
"panel_install.sh should build the compose URL after the interactive proxy choice"
|
||||
)
|
||||
|
||||
test_update_panel_asks_for_proxy_config() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/panel_install.sh"
|
||||
|
||||
local ask_called="0"
|
||||
|
||||
ask_proxy_config() {
|
||||
ask_called="1"
|
||||
PROXY_ENABLED="false"
|
||||
DOCKER_COMPOSEV4_URL=""
|
||||
DOCKER_COMPOSEV6_URL=""
|
||||
}
|
||||
|
||||
check_docker() {
|
||||
DOCKER_CMD="true"
|
||||
}
|
||||
|
||||
get_current_db_type() {
|
||||
echo "sqlite"
|
||||
}
|
||||
|
||||
resolve_latest_release_tag() {
|
||||
echo "v-test"
|
||||
}
|
||||
|
||||
upsert_env_var() { :; }
|
||||
check_ipv6_support() { return 1; }
|
||||
configure_docker_ipv6() { :; }
|
||||
docker() { return 0; }
|
||||
wait_for_backend_healthy() { return 0; }
|
||||
sleep() { :; }
|
||||
curl() { :; }
|
||||
|
||||
update_panel >/dev/null
|
||||
|
||||
assert_equals "1" "$ask_called" "update_panel should ask for proxy config before downloading"
|
||||
assert_equals \
|
||||
"https://github.com/${REPO}/releases/download/v-test/docker-compose-v4.yml" \
|
||||
"$DOCKER_COMPOSEV4_URL" \
|
||||
"update_panel should honor the prompted proxy choice"
|
||||
)
|
||||
|
||||
test_panel_install_script_accepts_proxy_url_env_without_prompt() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/panel_install.sh"
|
||||
|
||||
PROXY_ENABLED=""
|
||||
PROXY_URL="mirror.example.com"
|
||||
|
||||
ask_proxy_config >/dev/null < <(printf '\n\n')
|
||||
|
||||
assert_equals "true" "$PROXY_ENABLED" "panel_install.sh should treat PROXY_URL as enabling the proxy"
|
||||
assert_equals "mirror.example.com" "$PROXY_URL" "panel_install.sh should preserve PROXY_URL when provided via env"
|
||||
)
|
||||
|
||||
test_panel_install_script_defaults_proxy_on_eof() {
|
||||
local rc="0"
|
||||
local output
|
||||
local temp_script
|
||||
|
||||
temp_script=$(mktemp)
|
||||
sed '/^# 执行主函数$/,$d' "$ROOT_DIR/panel_install.sh" > "$temp_script"
|
||||
cat >> "$temp_script" <<'EOF'
|
||||
PROXY_ENABLED=""
|
||||
PROXY_URL=""
|
||||
ask_proxy_config >/dev/null < /dev/null
|
||||
printf '%s\n%s\n' "$PROXY_ENABLED" "$PROXY_URL"
|
||||
EOF
|
||||
|
||||
output=$(bash "$temp_script") || rc="$?"
|
||||
rm -f "$temp_script"
|
||||
|
||||
assert_equals "0" "$rc" "panel_install.sh should not fail when proxy prompt receives EOF"
|
||||
assert_equals $'true\ngcode.hostcentral.cc' "$output" "panel_install.sh should fall back to the default proxy on EOF"
|
||||
}
|
||||
|
||||
test_panel_install_script_uses_default_proxy() (
|
||||
set -euo pipefail
|
||||
load_script_without_main "$ROOT_DIR/panel_install.sh"
|
||||
|
||||
PROXY_ENABLED="true"
|
||||
PROXY_URL=""
|
||||
|
||||
local actual
|
||||
actual=$(maybe_proxy_url "https://github.com/example/release")
|
||||
|
||||
assert_equals \
|
||||
"https://gcode.hostcentral.cc/https://github.com/example/release" \
|
||||
"$actual" \
|
||||
"panel_install.sh should keep the default proxy when enabled"
|
||||
)
|
||||
|
||||
test_install_script_respects_disabled_proxy
|
||||
test_install_script_asks_for_proxy_config
|
||||
test_install_script_recomputes_download_url_after_prompt
|
||||
test_update_flux_agent_asks_for_proxy_config
|
||||
test_update_flux_agent_skips_proxy_prompt_when_not_installed
|
||||
test_install_script_accepts_proxy_url_env_without_prompt
|
||||
test_panel_install_script_can_disable_proxy
|
||||
test_panel_install_script_recomputes_compose_urls_after_prompt
|
||||
test_update_panel_asks_for_proxy_config
|
||||
test_panel_install_script_uses_default_proxy
|
||||
test_panel_install_script_accepts_proxy_url_env_without_prompt
|
||||
test_panel_install_script_defaults_proxy_on_eof
|
||||
|
||||
echo "install script proxy tests passed"
|
||||
Reference in New Issue
Block a user