mirror of
https://github.com/Sagit-chu/flvx.git
synced 2026-11-13 00:14:22 +08:00
sagit
7e81e1c65c
Persist upgrade jobs and progress across backend restarts; preserve Compose identity and database mounts, isolate backups, and fail safely on uncertain recreation. Add frontend recovery handling and lifecycle/permission regressions.
242 lines
8.8 KiB
Go
242 lines
8.8 KiB
Go
package handler
|
|
|
|
import (
|
|
"bytes"
|
|
"encoding/json"
|
|
"io"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"go-backend/internal/store/repo"
|
|
)
|
|
|
|
func TestSelectComposeAssetUsesIPv6Template(t *testing.T) {
|
|
exec := &systemUpgradeExecutor{deployDir: "/opt/flvx-panel", backendContainer: "flux-panel-backend"}
|
|
compose := []byte("networks:\n gost-network:\n enable_ipv6: true\n")
|
|
|
|
if got := exec.selectComposeAsset(compose); got != "docker-compose-v6.yml" {
|
|
t.Fatalf("selectComposeAsset() = %q, want %q", got, "docker-compose-v6.yml")
|
|
}
|
|
}
|
|
|
|
func TestDownloadReleaseAssetUsesGithubProxyWhenEnabled(t *testing.T) {
|
|
dbPath := filepath.Join(t.TempDir(), "test.db")
|
|
repoStore, err := repo.Open(dbPath)
|
|
if err != nil {
|
|
t.Fatalf("repo.Open() error = %v", err)
|
|
}
|
|
defer repoStore.Close()
|
|
|
|
h := &Handler{repo: repoStore}
|
|
originalBase := systemUpgradeReleaseBaseURL
|
|
systemUpgradeReleaseBaseURL = "https://example.invalid"
|
|
t.Cleanup(func() { systemUpgradeReleaseBaseURL = originalBase })
|
|
|
|
originalGet := systemUpgradeHTTPGet
|
|
defer func() { systemUpgradeHTTPGet = originalGet }()
|
|
|
|
var gotURL string
|
|
systemUpgradeHTTPGet = func(client *http.Client, url string) (*http.Response, error) {
|
|
gotURL = url
|
|
return &http.Response{
|
|
StatusCode: http.StatusOK,
|
|
Body: io.NopCloser(strings.NewReader("services:\n backend:\n image: test\n")),
|
|
}, nil
|
|
}
|
|
|
|
now := time.Now().UnixMilli()
|
|
if err := repoStore.UpsertConfig("github_proxy_enabled", "true", now); err != nil {
|
|
t.Fatalf("UpsertConfig() github_proxy_enabled error = %v", err)
|
|
}
|
|
if err := repoStore.UpsertConfig("github_proxy_url", "https://proxy.example.com", now); err != nil {
|
|
t.Fatalf("UpsertConfig() github_proxy_url error = %v", err)
|
|
}
|
|
|
|
data, err := h.downloadReleaseAsset("2.1.9", "docker-compose-v4.yml")
|
|
if err != nil {
|
|
t.Fatalf("downloadReleaseAsset() error = %v", err)
|
|
}
|
|
if !strings.Contains(string(data), "backend") {
|
|
t.Fatalf("downloadReleaseAsset() data = %q, want compose data", string(data))
|
|
}
|
|
|
|
wantURL := "https://proxy.example.com/https://example.invalid/Sagit-chu/flvx/releases/download/2.1.9/docker-compose-v4.yml"
|
|
if gotURL != wantURL {
|
|
t.Fatalf("download URL = %q, want %q", gotURL, wantURL)
|
|
}
|
|
}
|
|
|
|
func TestDownloadReleaseAssetRejectsOversizedBody(t *testing.T) {
|
|
dbPath := filepath.Join(t.TempDir(), "test.db")
|
|
repoStore, err := repo.Open(dbPath)
|
|
if err != nil {
|
|
t.Fatalf("repo.Open() error = %v", err)
|
|
}
|
|
defer repoStore.Close()
|
|
now := time.Now().UnixMilli()
|
|
if err := repoStore.UpsertConfig("github_proxy_enabled", "false", now); err != nil {
|
|
t.Fatalf("UpsertConfig() github_proxy_enabled error = %v", err)
|
|
}
|
|
|
|
originalBase := systemUpgradeReleaseBaseURL
|
|
systemUpgradeReleaseBaseURL = "https://example.invalid"
|
|
t.Cleanup(func() { systemUpgradeReleaseBaseURL = originalBase })
|
|
|
|
originalGet := systemUpgradeHTTPGet
|
|
defer func() { systemUpgradeHTTPGet = originalGet }()
|
|
systemUpgradeHTTPGet = func(client *http.Client, url string) (*http.Response, error) {
|
|
return &http.Response{
|
|
StatusCode: http.StatusOK,
|
|
Body: io.NopCloser(bytes.NewReader(bytes.Repeat([]byte("a"), maxSystemUpgradeComposeAssetBytes+1))),
|
|
}, nil
|
|
}
|
|
|
|
h := &Handler{repo: repoStore}
|
|
_, err = h.downloadReleaseAsset("2.1.9", "docker-compose-v4.yml")
|
|
if err == nil || !strings.Contains(err.Error(), "过大") {
|
|
t.Fatalf("downloadReleaseAsset() error = %v, want oversized error", err)
|
|
}
|
|
}
|
|
|
|
func TestSelectComposeAssetUsesIPv6TemplateForYAMLVariants(t *testing.T) {
|
|
exec := &systemUpgradeExecutor{deployDir: "/opt/flvx-panel", backendContainer: "flux-panel-backend"}
|
|
for _, compose := range [][]byte{
|
|
[]byte("networks:\n gost-network:\n enable_ipv6:true\n"),
|
|
[]byte("networks:\n gost-network:\n enable_ipv6: True\n"),
|
|
[]byte("networks:\n gost-network:\n enable_ipv6: \"true\"\n"),
|
|
[]byte("networks:\n gost-network:\n enable_ipv6: 'true'\n"),
|
|
[]byte("networks:\n gost-network:\n enable_ipv6: true # comment\n"),
|
|
} {
|
|
if got := exec.selectComposeAsset(compose); got != "docker-compose-v6.yml" {
|
|
t.Fatalf("selectComposeAsset(%q) = %q, want %q", string(compose), got, "docker-compose-v6.yml")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSelectComposeAssetFallsBackToIPv4Template(t *testing.T) {
|
|
exec := &systemUpgradeExecutor{deployDir: "/opt/flvx-panel", backendContainer: "flux-panel-backend"}
|
|
compose := []byte("services:\n backend:\n image: test\n")
|
|
|
|
if got := exec.selectComposeAsset(compose); got != "docker-compose-v4.yml" {
|
|
t.Fatalf("selectComposeAsset() = %q, want %q", got, "docker-compose-v4.yml")
|
|
}
|
|
}
|
|
|
|
func TestValidateBackendContainerNameRejectsUnsafeValue(t *testing.T) {
|
|
if err := validateBackendContainerName("flux-panel-backend;rm -rf /"); err == nil {
|
|
t.Fatal("expected unsafe container name to fail validation")
|
|
}
|
|
}
|
|
|
|
func TestSystemVersionRejectsWrongMethod(t *testing.T) {
|
|
h := &Handler{}
|
|
req := httptest.NewRequest(http.MethodGet, "/api/v1/system/version", nil)
|
|
rr := httptest.NewRecorder()
|
|
|
|
h.systemVersion(rr, req)
|
|
|
|
if !strings.Contains(rr.Body.String(), "请求失败") {
|
|
t.Fatalf("expected wrong-method response, got %s", rr.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestSystemUpgradeRejectsConcurrentRequests(t *testing.T) {
|
|
h := &Handler{}
|
|
h.systemUpgradeMu.Lock()
|
|
defer h.systemUpgradeMu.Unlock()
|
|
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/system/upgrade", strings.NewReader(`{"channel":"stable"}`))
|
|
rr := httptest.NewRecorder()
|
|
|
|
h.systemUpgrade(rr, req)
|
|
|
|
if !strings.Contains(rr.Body.String(), systemUpgradeConflictError) {
|
|
t.Fatalf("expected conflict message, got %s", rr.Body.String())
|
|
}
|
|
}
|
|
|
|
func TestSystemUpgradeFailsFastBeforeMutatingFiles(t *testing.T) {
|
|
dir := t.TempDir()
|
|
composePath := filepath.Join(dir, "docker-compose.yml")
|
|
envPath := filepath.Join(dir, ".env")
|
|
if err := os.WriteFile(composePath, []byte("services:\n backend:\n image: test\n"), 0o644); err != nil {
|
|
t.Fatalf("WriteFile() compose error = %v", err)
|
|
}
|
|
if err := os.WriteFile(envPath, []byte("FLUX_VERSION=2.1.8\nJWT_SECRET=test\n"), 0o600); err != nil {
|
|
t.Fatalf("WriteFile() env error = %v", err)
|
|
}
|
|
|
|
fakeDockerDir := t.TempDir()
|
|
fakeDockerPath := filepath.Join(fakeDockerDir, "docker")
|
|
fakeDockerScript := "#!/bin/sh\ncase \"$1\" in\n --version)\n echo 'Docker version 27.0.0'\n exit 0\n ;;&\n compose)\n if [ \"$2\" = version ]; then\n echo 'Docker Compose version v2.33.0'\n exit 0\n fi\n exit 0\n ;;&\n inspect)\n echo 'No such object: flux-panel-backend' >&2\n exit 1\n ;;&\n *)\n exit 0\n ;;&\n esac\n"
|
|
if err := os.WriteFile(fakeDockerPath, []byte(fakeDockerScript), 0o755); err != nil {
|
|
t.Fatalf("WriteFile() fake docker error = %v", err)
|
|
}
|
|
t.Setenv("PATH", fakeDockerDir+string(os.PathListSeparator)+os.Getenv("PATH"))
|
|
t.Setenv(panelDeployDirEnv, dir)
|
|
t.Setenv(panelBackendContainerEnv, "flux-panel-backend")
|
|
|
|
h := &Handler{}
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/system/upgrade", strings.NewReader(`{"channel":"stable"}`))
|
|
rr := httptest.NewRecorder()
|
|
|
|
h.systemUpgrade(rr, req)
|
|
|
|
if !strings.Contains(rr.Body.String(), "当前环境不支持面板自升级") {
|
|
t.Fatalf("expected fail-fast capability error, got %s", rr.Body.String())
|
|
}
|
|
if _, err := os.Stat(composePath + ".upgrade.bak"); !os.IsNotExist(err) {
|
|
t.Fatalf("expected no compose backup, got err=%v", err)
|
|
}
|
|
if _, err := os.Stat(envPath + ".upgrade.bak"); !os.IsNotExist(err) {
|
|
t.Fatalf("expected no env backup, got err=%v", err)
|
|
}
|
|
composeData, err := os.ReadFile(composePath)
|
|
if err != nil {
|
|
t.Fatalf("ReadFile() compose error = %v", err)
|
|
}
|
|
if string(composeData) != "services:\n backend:\n image: test\n" {
|
|
t.Fatalf("compose mutated unexpectedly: %q", string(composeData))
|
|
}
|
|
envData, err := os.ReadFile(envPath)
|
|
if err != nil {
|
|
t.Fatalf("ReadFile() env error = %v", err)
|
|
}
|
|
if string(envData) != "FLUX_VERSION=2.1.8\nJWT_SECRET=test\n" {
|
|
t.Fatalf("env mutated unexpectedly: %q", string(envData))
|
|
}
|
|
}
|
|
|
|
func TestDecodeSystemUpgradeRequestRejectsTruncatedJSON(t *testing.T) {
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/system/check-updates", strings.NewReader(`{"channel":"stable"`))
|
|
var payload systemUpgradeRequest
|
|
|
|
if err := decodeSystemUpgradeRequest(req, &payload); err == nil {
|
|
t.Fatal("expected truncated JSON to be rejected")
|
|
}
|
|
}
|
|
|
|
func TestDecodeSystemUpgradeRequestAllowsEmptyBody(t *testing.T) {
|
|
req := httptest.NewRequest(http.MethodPost, "/api/v1/system/check-updates", strings.NewReader(""))
|
|
var payload systemUpgradeRequest
|
|
|
|
if err := decodeSystemUpgradeRequest(req, &payload); err != nil {
|
|
t.Fatalf("expected empty body to be accepted, got %v", err)
|
|
}
|
|
}
|
|
|
|
func TestSystemUpgradeVersionDataSurfacesLookupFailureReason(t *testing.T) {
|
|
data, err := json.Marshal(systemUpgradeVersionData{Reason: "GitHub unavailable"})
|
|
if err != nil {
|
|
t.Fatalf("Marshal() error = %v", err)
|
|
}
|
|
if !strings.Contains(string(data), `"reason":"GitHub unavailable"`) {
|
|
t.Fatalf("expected reason field in JSON, got %s", string(data))
|
|
}
|
|
}
|