From cea80b482ebc5848d7246e7a74f2557384750070 Mon Sep 17 00:00:00 2001 From: chaptergy Date: Wed, 4 Aug 2021 13:47:44 +0200 Subject: [PATCH 1/3] Fixes certificate renewal for dns challenges --- docker/rootfs/etc/letsencrypt.ini | 1 - 1 file changed, 1 deletion(-) diff --git a/docker/rootfs/etc/letsencrypt.ini b/docker/rootfs/etc/letsencrypt.ini index 3565d6e..25c375e 100644 --- a/docker/rootfs/etc/letsencrypt.ini +++ b/docker/rootfs/etc/letsencrypt.ini @@ -1,4 +1,3 @@ text = True non-interactive = True -authenticator = webroot webroot-path = /data/letsencrypt-acme-challenge From d34691152ca5efd93087a343d423fadcd6e06989 Mon Sep 17 00:00:00 2001 From: chaptergy Date: Wed, 4 Aug 2021 13:52:20 +0200 Subject: [PATCH 2/3] Fixes renewal unused http certificates --- backend/templates/default.conf | 2 ++ docker/rootfs/etc/nginx/conf.d/default.conf | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/backend/templates/default.conf b/backend/templates/default.conf index 7eef11f..5196f28 100644 --- a/backend/templates/default.conf +++ b/backend/templates/default.conf @@ -16,6 +16,8 @@ server { error_log /data/logs/default-host_error.log warn; {% include "_exploits.conf" %} + include conf.d/include/letsencrypt-acme-challenge.conf; + {%- if value == "404" %} location / { return 404; diff --git a/docker/rootfs/etc/nginx/conf.d/default.conf b/docker/rootfs/etc/nginx/conf.d/default.conf index a763498..81d6ae4 100644 --- a/docker/rootfs/etc/nginx/conf.d/default.conf +++ b/docker/rootfs/etc/nginx/conf.d/default.conf @@ -9,9 +9,10 @@ server { server_name localhost-nginx-proxy-manager; access_log /data/logs/fallback_access.log standard; - error_log /dev/null crit; + error_log /data/logs/fallback_error.log warn; include conf.d/include/assets.conf; include conf.d/include/block-exploits.conf; + include conf.d/include/letsencrypt-acme-challenge.conf; location / { index index.html; From 83c5c55f32be3792330ba860c77273a84e247628 Mon Sep 17 00:00:00 2001 From: chaptergy Date: Fri, 6 Aug 2021 10:56:06 +0200 Subject: [PATCH 3/3] Fixes creation of certificates using the http challenge --- backend/internal/certificate.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/backend/internal/certificate.js b/backend/internal/certificate.js index 96972fe..661950d 100644 --- a/backend/internal/certificate.js +++ b/backend/internal/certificate.js @@ -758,6 +758,7 @@ const internalCertificate = { }, /** + * Request a certificate using the http challenge * @param {Object} certificate the certificate row * @returns {Promise} */ @@ -768,6 +769,7 @@ const internalCertificate = { '--config "' + letsencryptConfig + '" ' + '--cert-name "npm-' + certificate.id + '" ' + '--agree-tos ' + + '--authenticator webroot ' + '--email "' + certificate.meta.letsencrypt_email + '" ' + '--preferred-challenges "dns,http" ' + '--domains "' + certificate.domain_names.join(',') + '" ' +