autoresearch iter 29: CORDIS contracts DTO must not carry a table name

This commit is contained in:
ryan
2026-08-29 18:45:17 +08:00
parent 4412093d05
commit 2ff0cb87c9
3 changed files with 18 additions and 9 deletions
-5
View File
@@ -29,11 +29,6 @@ type UserDTO struct {
UpdatedAt time.Time `json:"updated_at"`
}
// TableName returns w_users.
func (UserDTO) TableName() string {
return "w_users"
}
// OAuthUserInfoDTO contains user identity claims obtained from an OAuth provider.
type OAuthUserInfoDTO struct {
ID uint64 `json:"id"`
@@ -666,11 +666,11 @@ func TestUploadAccessModeAccessControl(t *testing.T) {
user2 := &contracts.UserDTO{ID: 1002, Username: "user2"}
// Seed user1
if err := dbConn.Create(user1).Error; err != nil {
if err := dbConn.Table("w_users").Create(user1).Error; err != nil {
t.Fatalf("create test user1 failed: %v", err)
}
// Seed user2
if err := dbConn.Create(user2).Error; err != nil {
if err := dbConn.Table("w_users").Create(user2).Error; err != nil {
t.Fatalf("create test user2 failed: %v", err)
}
@@ -861,8 +861,8 @@ func TestUserUploadManagement(t *testing.T) {
user1 := &contracts.UserDTO{ID: 1001, Username: "user1"}
user2 := &contracts.UserDTO{ID: 1002, Username: "user2"}
_ = dbConn.Create(user1)
_ = dbConn.Create(user2)
_ = dbConn.Table("w_users").Create(user1)
_ = dbConn.Table("w_users").Create(user2)
router1 := setupTestRouter(user1)
router2 := setupTestRouter(user2)
+14
View File
@@ -90,6 +90,20 @@ else
log_pass "backend/core/contracts/ 纯抽象无侵入"
fi
# 2.2 契约层禁止持久化耦合(表名映射 / ORM tag)
# DTO 一旦携带 TableName(),调用方就能用 Table("w_users") 直查他人表,
# 单表所有者原则与 contracts 抽象同时失效。
# 注意:不禁 gorm import 本身 —— DBService 契约合法返回 gorm 类型。
CONTRACTS_PERSISTENCE=$(rg -n 'func .*\)?\s*TableName\(\)|\bgorm:"' \
"${BACKEND_DIR}/core/contracts/" --glob '*.go' -g '!*_test.go' || true)
if [ -n "${CONTRACTS_PERSISTENCE}" ]; then
log_fail "backend/core/contracts/ 为跨插件纯 DTO,严禁携带表名映射或 ORM tag(持久化归属唯一所有者插件,否则调用方可绕过契约直读他人表):"
echo "${CONTRACTS_PERSISTENCE}" >&2
else
log_pass "backend/core/contracts/ 无持久化耦合"
fi
# ==============================================================================
# 3. 基础包纯洁度 (backend/pkg/ Purity)
# ==============================================================================