OpenFlare/internal/apps/agent/nginx/manager_test.go

// Copyright 2026 Arctel.net
// SPDX-License-Identifier: Apache-2.0

package nginx

import (
	"context"
	"errors"
	"fmt"
	"net"
	"net/http"
	"os"
	"path/filepath"
	"reflect"
	"runtime"
	"strings"
	"testing"

	"github.com/Rain-kl/Wavelet/internal/apps/agent/protocol"
	sharedprotocol "github.com/Rain-kl/Wavelet/pkg/protocol"
	openrestyrender "github.com/Rain-kl/Wavelet/pkg/render/openresty"
)

type runCall struct {
	name string
	args []string
}

type fakeRunner struct {
	calls []runCall
	runFn func(name string, args ...string) ([]byte, error)
}

type fakeExecutor struct {
	testErr   error
	reloadErr error
}

type scriptedExecutor struct {
	testErrors   []error
	testCalls    int
	reloadErrors []error
	reloadCalls  int
}

func (r *fakeRunner) Run(ctx context.Context, name string, args ...string) ([]byte, error) {
	r.calls = append(r.calls, runCall{name: name, args: append([]string{}, args...)})
	if r.runFn != nil {
		return r.runFn(name, args...)
	}
	return nil, nil
}

func (e *fakeExecutor) Test(ctx context.Context) error {
	return e.testErr
}

func (e *fakeExecutor) Reload(ctx context.Context) error {
	return e.reloadErr
}

func (e *fakeExecutor) EnsureRuntime(ctx context.Context, recreate bool) error {
	return nil
}

func (e *fakeExecutor) CheckHealth(ctx context.Context) error {
	return e.testErr
}

func (e *fakeExecutor) Restart(ctx context.Context) error {
	return e.reloadErr
}

func (e *scriptedExecutor) Test(ctx context.Context) error {
	index := e.testCalls
	e.testCalls++
	if index >= len(e.testErrors) {
		return nil
	}
	return e.testErrors[index]
}

func (e *scriptedExecutor) Reload(ctx context.Context) error {
	index := e.reloadCalls
	e.reloadCalls++
	if index >= len(e.reloadErrors) {
		return nil
	}
	return e.reloadErrors[index]
}

func (e *scriptedExecutor) EnsureRuntime(ctx context.Context, recreate bool) error {
	return nil
}

func (e *scriptedExecutor) CheckHealth(ctx context.Context) error {
	return nil
}

func (e *scriptedExecutor) Restart(ctx context.Context) error {
	return nil
}

func TestPathExecutorCommands(t *testing.T) {
	runner := &fakeRunner{}
	executor := &PathExecutor{
		Path:       "/usr/local/openresty/nginx/sbin/openresty",
		ConfigPath: "/data/etc/nginx/nginx.conf",
		Runner:     runner,
	}

	if err := executor.Test(context.Background()); err != nil {
		t.Fatalf("Test failed: %v", err)
	}
	if err := executor.Reload(context.Background()); err != nil {
		t.Fatalf("Reload failed: %v", err)
	}

	expected := []runCall{
		{name: "/usr/local/openresty/nginx/sbin/openresty", args: []string{"-t", "-c", "/data/etc/nginx/nginx.conf"}},
		{name: "/usr/local/openresty/nginx/sbin/openresty", args: []string{"-s", "reload", "-c", "/data/etc/nginx/nginx.conf"}},
	}
	if !reflect.DeepEqual(runner.calls, expected) {
		t.Fatalf("unexpected calls: %#v", runner.calls)
	}
}

func TestPathExecutorEnsureRuntimeNoop(t *testing.T) {
	runner := &fakeRunner{}
	executor := &PathExecutor{
		Path:       "/usr/local/openresty/nginx/sbin/openresty",
		ConfigPath: "/data/etc/nginx/nginx.conf",
		Runner:     runner,
	}
	if err := executor.EnsureRuntime(context.Background(), true); err != nil {
		t.Fatalf("EnsureRuntime failed: %v", err)
	}
	if len(runner.calls) != 2 {
		t.Fatalf("expected test and reload calls, got %d", len(runner.calls))
	}
}

func TestPathExecutorRestartIgnoresMissingPID(t *testing.T) {
	runner := &fakeRunner{
		runFn: func(name string, args ...string) ([]byte, error) {
			if len(args) == 2 && args[0] == "-s" && args[1] == "quit" {
				return []byte("openresty: [error] invalid PID number \"\" in \"/usr/local/openresty/nginx/logs/nginx.pid\""), errors.New("exit status 1")
			}
			return []byte(""), nil
		},
	}
	executor := &PathExecutor{
		Path:       "/usr/local/openresty/nginx/sbin/openresty",
		ConfigPath: "/data/etc/nginx/nginx.conf",
		Runner:     runner,
	}
	if err := executor.Restart(context.Background()); err != nil {
		t.Fatalf("Restart failed: %v", err)
	}
	if len(runner.calls) != 2 {
		t.Fatalf("expected 2 restart calls, got %d", len(runner.calls))
	}
}

func TestPathExecutorReloadStartsWhenRuntimeIsNotRunning(t *testing.T) {
	runner := &fakeRunner{
		runFn: func(name string, args ...string) ([]byte, error) {
			if len(args) >= 2 && args[0] == "-s" && args[1] == "reload" {
				return []byte("openresty: [error] invalid PID number \"\" in \"/usr/local/openresty/nginx/logs/nginx.pid\""), errors.New("exit status 1")
			}
			return []byte(""), nil
		},
	}
	executor := &PathExecutor{
		Path:       "/usr/local/openresty/nginx/sbin/openresty",
		ConfigPath: "/data/etc/nginx/nginx.conf",
		Runner:     runner,
	}
	if err := executor.Reload(context.Background()); err != nil {
		t.Fatalf("Reload failed: %v", err)
	}
	expected := []runCall{
		{name: "/usr/local/openresty/nginx/sbin/openresty", args: []string{"-s", "reload", "-c", "/data/etc/nginx/nginx.conf"}},
		{name: "/usr/local/openresty/nginx/sbin/openresty", args: []string{"-c", "/data/etc/nginx/nginx.conf"}},
	}
	if !reflect.DeepEqual(runner.calls, expected) {
		t.Fatalf("unexpected calls: %#v", runner.calls)
	}
}

func TestDetectVersionFromBinary(t *testing.T) {
	version, err := detectVersion(context.Background(), ExecutorOptions{
		NginxPath: "/usr/local/openresty/nginx/sbin/openresty",
	}, &fakeRunner{
		runFn: func(name string, args ...string) ([]byte, error) {
			return []byte("nginx version: openresty/1.27.1.2\n"), nil
		},
	})
	if err != nil {
		t.Fatalf("detectVersion failed: %v", err)
	}
	if version != "1.27.1.2" {
		t.Fatalf("unexpected version: %s", version)
	}
}

func TestManagerApplyAndChecksumIncludeMainConfig(t *testing.T) {
	tempDir := t.TempDir()
	mainPath := filepath.Join(tempDir, "nginx.conf")
	routePath := filepath.Join(tempDir, "conf.d", "openflare_routes.conf")
	certDir := filepath.Join(tempDir, "certs")
	accessLogPath := filepath.Join(tempDir, "var", "log", "openflare", "access.log")
	manager := &Manager{
		MainConfigPath:  mainPath,
		RouteConfigPath: routePath,
		AccessLogPath:   accessLogPath,
		CertDir:         certDir,
		NginxCertDir:    "/etc/nginx/openflare-certs",
		LuaDir:          filepath.Join(tempDir, "lua"),
		NginxLuaDir:     "/etc/nginx/openflare-lua",
		Executor:        &fakeExecutor{},
	}

	outcome := manager.Apply(
		context.Background(),
		"include __OPENFLARE_ROUTE_CONFIG__;\naccess_log __OPENFLARE_ACCESS_LOG__ openflare_json;\n",
		"ssl_certificate __OPENFLARE_CERT_DIR__/1.crt;\n",
		[]protocol.SupportFile{{Path: "1.crt", Content: "cert"}},
	)
	if outcome.Status != ApplyStatusSuccess {
		t.Fatalf("Apply failed: %#v", outcome)
	}

	mainData, err := os.ReadFile(mainPath)
	if err != nil {
		t.Fatalf("failed to read main config: %v", err)
	}
	expectedMain := "include " + routePath + ";\naccess_log " + filepath.ToSlash(accessLogPath) + " openflare_json;\n"
	if string(mainData) != expectedMain {
		t.Fatalf("unexpected main config: %s", string(mainData))
	}

	routeData, err := os.ReadFile(routePath)
	if err != nil {
		t.Fatalf("failed to read route config: %v", err)
	}
	if string(routeData) != "ssl_certificate /etc/nginx/openflare-certs/1.crt;\n" {
		t.Fatalf("unexpected route config: %s", string(routeData))
	}

	value, err := manager.CurrentChecksum()
	if err != nil {
		t.Fatalf("CurrentChecksum failed: %v", err)
	}
	expected := bundleChecksum(
		"include __OPENFLARE_ROUTE_CONFIG__;\naccess_log __OPENFLARE_ACCESS_LOG__ openflare_json;\n",
		"ssl_certificate __OPENFLARE_CERT_DIR__/1.crt;\n",
		[]protocol.SupportFile{{Path: "1.crt", Content: "cert"}},
	)
	if value != expected {
		t.Fatalf("unexpected checksum: got %s want %s", value, expected)
	}
}

func TestParseExtVersionIgnoresDockerEntrypointPaths(t *testing.T) {
	output := strings.Join([]string{
		"/docker-entrypoint.sh: /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh: info: can not modify /etc/nginx/conf.d/default.conf (read-only file system?)",
		"nginx version: openresty/1.27.1.2",
	}, "\n")

	version := parseExtVersion(output)
	if version != "1.27.1.2" {
		t.Fatalf("unexpected version: %s", version)
	}
}

func TestManagerApplyWritesSupportFilesAndReplacesPlaceholder(t *testing.T) {
	tempDir := t.TempDir()
	manager := &Manager{
		MainConfigPath:               filepath.Join(tempDir, "nginx.conf"),
		RouteConfigPath:              filepath.Join(tempDir, "routes.conf"),
		CertDir:                      filepath.Join(tempDir, "certs"),
		NginxCertDir:                 "/etc/nginx/openflare-certs",
		LuaDir:                       filepath.Join(tempDir, "lua"),
		NginxLuaDir:                  "/etc/nginx/openflare-lua",
		OpenrestyObservabilityListen: "18081",
		OpenrestyResolverDirective:   "    resolver 127.0.0.11 valid=30s ipv6=off;\n    resolver_timeout 5s;\n",
		Executor:                     &fakeExecutor{},
	}

	outcome := manager.Apply(context.Background(), "include __OPENFLARE_ROUTE_CONFIG__;\n__OPENFLARE_RESOLVER_DIRECTIVE__server { listen __OPENFLARE_OBSERVABILITY_LISTEN__; }", "ssl_certificate __OPENFLARE_CERT_DIR__/1.crt;", []protocol.SupportFile{
		{Path: "1.crt", Content: "cert-data"},
		{Path: "1.key", Content: "key-data"},
	})
	if outcome.Status != ApplyStatusSuccess {
		t.Fatalf("Apply failed: %#v", outcome)
	}

	routeData, err := os.ReadFile(manager.RouteConfigPath)
	if err != nil {
		t.Fatalf("failed to read route config: %v", err)
	}
	if !strings.Contains(string(routeData), "/etc/nginx/openflare-certs/1.crt") {
		t.Fatalf("expected placeholder replacement in route config, got %s", string(routeData))
	}
	renderedRoute := manager.renderRouteConfig("access_by_lua_file __OPENFLARE_LUA_DIR__/pow/check.lua;\nlocation /.within.website/x/cmd/anubis/static/ { alias __OPENFLARE_POW_STATIC_DIR__/; }\nio.open(\"__OPENFLARE_ERROR_PAGE_TMPL__\", \"r\")\n")
	if !strings.Contains(renderedRoute, "access_by_lua_file /etc/nginx/openflare-lua/pow/check.lua;") {
		t.Fatalf("expected lua dir placeholder replacement in route config, got %s", renderedRoute)
	}
	if !strings.Contains(renderedRoute, "alias /etc/nginx/openflare-lua/pow/static/;") {
		t.Fatalf("expected pow static dir placeholder replacement in route config, got %s", renderedRoute)
	}
	wantErrorPagePath := filepath.ToSlash(filepath.Join(manager.NginxCertDir, openrestyrender.OriginErrorPageSupportPath))
	if !strings.Contains(renderedRoute, `io.open("`+wantErrorPagePath+`", "r")`) {
		t.Fatalf("expected error page template placeholder replacement, got %s", renderedRoute)
	}
	mainData, err := os.ReadFile(manager.MainConfigPath)
	if err != nil {
		t.Fatalf("failed to read main config: %v", err)
	}
	if !strings.Contains(string(mainData), "listen 18081;") {
		t.Fatalf("expected observability listen placeholder replacement in main config, got %s", string(mainData))
	}
	if !strings.Contains(string(mainData), "resolver 127.0.0.11 valid=30s ipv6=off;") {
		t.Fatalf("expected resolver directive placeholder replacement in main config, got %s", string(mainData))
	}
	certData, err := os.ReadFile(filepath.Join(manager.CertDir, "1.crt"))
	if err != nil {
		t.Fatalf("failed to read cert file: %v", err)
	}
	if string(certData) != "cert-data" {
		t.Fatalf("unexpected cert file content: %s", string(certData))
	}
	luaInfo, err := os.Stat(filepath.Join(manager.LuaDir, "log.lua"))
	if err != nil {
		t.Fatalf("expected managed lua file to exist, stat err = %v", err)
	}
	if runtime.GOOS != "windows" && luaInfo.Mode().Perm() != 0o644 {
		t.Fatalf("unexpected lua mode: %o", luaInfo.Mode().Perm())
	}
}

func TestManagerApplyShipsSWAssetsAndReplacesSWDirPlaceholder(t *testing.T) {
	tempDir := t.TempDir()
	manager := &Manager{
		MainConfigPath:  filepath.Join(tempDir, "nginx.conf"),
		RouteConfigPath: filepath.Join(tempDir, "routes.conf"),
		CertDir:         filepath.Join(tempDir, "certs"),
		NginxCertDir:    "/etc/nginx/openflare-certs",
		LuaDir:          filepath.Join(tempDir, "lua"),
		NginxLuaDir:     "/etc/nginx/openflare-lua",
		Executor:        &fakeExecutor{},
	}

	outcome := manager.Apply(
		context.Background(),
		"include __OPENFLARE_ROUTE_CONFIG__;",
		"alias __OPENFLARE_SW_DIR__/sw.js;\nalias __OPENFLARE_SW_DIR__/offline.html;\ncontent_by_lua_file __OPENFLARE_SW_DIR__/challenge.lua;\nrequire(\"__OPENFLARE_LUA_DIR__\")",
		[]protocol.SupportFile{
			{Path: "sw/sw.js", Content: "js"},
			{Path: "sw/offline.html", Content: "html"},
		},
	)
	if outcome.Status != ApplyStatusSuccess {
		t.Fatalf("Apply failed: %#v", outcome)
	}

	routeData, err := os.ReadFile(manager.RouteConfigPath)
	if err != nil {
		t.Fatalf("failed to read route config: %v", err)
	}
	rendered := string(routeData)
	for _, want := range []string{
		"/etc/nginx/openflare-certs/sw/sw.js",
		"/etc/nginx/openflare-certs/sw/offline.html",
		"/etc/nginx/openflare-certs/sw/challenge.lua",
	} {
		if !strings.Contains(rendered, want) {
			t.Fatalf("route config missing %q, got %s", want, rendered)
		}
	}
	if strings.Contains(rendered, openrestyrender.SWDirPlaceholder) {
		t.Fatalf("route config still contains SW dir placeholder: %s", rendered)
	}

	for _, path := range []string{
		filepath.Join(manager.CertDir, "sw", "sw.js"),
		filepath.Join(manager.CertDir, "sw", "offline.html"),
		filepath.Join(manager.CertDir, "sw", "challenge.lua"),
		filepath.Join(manager.CertDir, "sw", "runtime.lua"),
	} {
		if _, err := os.Stat(path); err != nil {
			t.Fatalf("expected SW asset %s to exist: %v", path, err)
		}
	}
	for _, path := range []string{
		filepath.Join(manager.LuaDir, "sw", "challenge.lua"),
		filepath.Join(manager.LuaDir, "sw", "runtime.lua"),
	} {
		if _, err := os.Stat(path); err != nil {
			t.Fatalf("expected SW lua asset %s to exist: %v", path, err)
		}
	}

	checksum, err := manager.CurrentChecksum()
	if err != nil {
		t.Fatalf("CurrentChecksum failed: %v", err)
	}
	expected := bundleChecksum(
		"include __OPENFLARE_ROUTE_CONFIG__;",
		"alias __OPENFLARE_SW_DIR__/sw.js;\nalias __OPENFLARE_SW_DIR__/offline.html;\ncontent_by_lua_file __OPENFLARE_SW_DIR__/challenge.lua;\nrequire(\"__OPENFLARE_LUA_DIR__\")",
		[]protocol.SupportFile{
			{Path: "sw/sw.js", Content: "js"},
			{Path: "sw/offline.html", Content: "html"},
		},
	)
	if checksum != expected {
		t.Fatalf("unexpected checksum: got %s want %s", checksum, expected)
	}
}

func TestManagerRenderMainConfigInitializesWAFRuntimeInWorker(t *testing.T) {
	manager := &Manager{NginxLuaDir: "/etc/nginx/openflare-lua"}
	rendered := manager.renderMainConfig("events {}\nhttp {\n    lua_shared_dict openflare_waf_config 1m;\n    server {}\n}\n")
	want := `init_worker_by_lua_block { require("waf.runtime").init() }`
	if !strings.Contains(rendered, want) {
		t.Fatalf("expected worker-time WAF initialization %q, got:\n%s", want, rendered)
	}
}

func TestManagerRenderMainConfigMergesExistingWorkerInitializer(t *testing.T) {
	manager := &Manager{NginxLuaDir: "/etc/nginx/openflare-lua"}
	rendered := manager.renderMainConfig("http {\n    lua_shared_dict openflare_waf_config 1m;\n    init_worker_by_lua_file /etc/nginx/openflare-lua/observability/init.lua;\n}\n")
	if strings.Count(rendered, "init_worker_by_lua_") != 1 {
		t.Fatalf("expected one merged worker initializer, got:\n%s", rendered)
	}
	if !strings.Contains(rendered, `require("waf.runtime").init()`) {
		t.Fatalf("expected WAF initialization in merged block, got:\n%s", rendered)
	}
	if !strings.Contains(rendered, `dofile("/etc/nginx/openflare-lua/observability/init.lua")`) {
		t.Fatalf("expected existing worker initializer to be preserved, got:\n%s", rendered)
	}
}

func TestManagerCheckHealthUsesStubStatusInsteadOfConfigTest(t *testing.T) {
	listener, err := net.Listen("tcp", "127.0.0.1:0")
	if err != nil {
		t.Fatalf("Listen failed: %v", err)
	}
	port := listener.Addr().(*net.TCPAddr).Port
	server := &http.Server{
		Handler: http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
			if r.URL.Path != "/openflare/stub_status" {
				http.NotFound(w, r)
				return
			}
			w.WriteHeader(http.StatusOK)
			_, _ = w.Write([]byte("Active connections: 1\n"))
		}),
	}
	go func() {
		_ = server.Serve(listener)
	}()
	defer server.Shutdown(context.Background())

	mainPath := filepath.Join(t.TempDir(), "nginx.conf")
	if err := os.WriteFile(mainPath, []byte("main"), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	manager := &Manager{
		MainConfigPath:             mainPath,
		OpenrestyObservabilityPort: port,
		Executor: &fakeExecutor{
			testErr: errors.New("openresty -t should not be called"),
		},
	}
	if err := manager.CheckHealth(context.Background()); err != nil {
		t.Fatalf("CheckHealth failed: %v", err)
	}
}

func TestManagerCheckHealthFailsWhenStubStatusUnavailable(t *testing.T) {
	listener, err := net.Listen("tcp", "127.0.0.1:0")
	if err != nil {
		t.Fatalf("Listen failed: %v", err)
	}
	port := listener.Addr().(*net.TCPAddr).Port
	if err := listener.Close(); err != nil {
		t.Fatalf("listener close failed: %v", err)
	}

	mainPath := filepath.Join(t.TempDir(), "nginx.conf")
	if err := os.WriteFile(mainPath, []byte("main"), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	manager := &Manager{
		MainConfigPath:             mainPath,
		OpenrestyObservabilityPort: port,
		Executor:                   &fakeExecutor{},
	}
	if err := manager.CheckHealth(context.Background()); err == nil {
		t.Fatal("expected CheckHealth to fail when stub_status is unavailable")
	}
}

func TestResolverDirectiveUsesExplicitResolvers(t *testing.T) {
	got := ResolverDirective([]string{"10.0.0.2", "1.1.1.1"})
	if !strings.Contains(got, "resolver 10.0.0.2 1.1.1.1") {
		t.Fatalf("expected explicit resolver directive, got %q", got)
	}
}

func TestParseResolverAddressesFiltersLoopbackForDocker(t *testing.T) {
	content := strings.Join([]string{
		"nameserver 127.0.0.53",
		"nameserver 10.0.0.2",
		"nameserver ::1",
		"nameserver 1.1.1.1",
	}, "\n")
	got := parseResolverAddresses(content, true)
	expected := []string{"10.0.0.2", "1.1.1.1"}
	if !reflect.DeepEqual(got, expected) {
		t.Fatalf("unexpected docker resolvers: got %#v want %#v", got, expected)
	}
}

func TestParseResolverAddressesKeepsLoopbackForLocalBinary(t *testing.T) {
	content := strings.Join([]string{
		"nameserver 127.0.0.53",
		"nameserver 10.0.0.2",
	}, "\n")
	got := parseResolverAddresses(content, false)
	expected := []string{"127.0.0.53", "10.0.0.2"}
	if !reflect.DeepEqual(got, expected) {
		t.Fatalf("unexpected local resolvers: got %#v want %#v", got, expected)
	}
}

func TestRequiresRuntimeResolver(t *testing.T) {
	testCases := []struct {
		name      string
		originURL string
		want      bool
	}{
		{name: "hostname", originURL: "https://origin.internal", want: true},
		{name: "ipv4", originURL: "https://10.0.0.8", want: false},
		{name: "ipv6", originURL: "https://[2001:db8::1]", want: false},
		{name: "invalid", originURL: "://bad", want: false},
	}

	for _, testCase := range testCases {
		if got := RequiresRuntimeResolver(testCase.originURL); got != testCase.want {
			t.Fatalf("%s: got %v want %v", testCase.name, got, testCase.want)
		}
	}
}

func TestWriteCertFilesKeepsBaseDirAndRemovesStaleFiles(t *testing.T) {
	tempDir := t.TempDir()
	certDir := filepath.Join(tempDir, "certs")
	if err := os.MkdirAll(filepath.Join(certDir, "stale"), 0o755); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}
	if err := os.WriteFile(filepath.Join(certDir, "stale", "old.crt"), []byte("old"), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	manager := &Manager{CertDir: certDir}

	if err := manager.writeCertFiles([]protocol.SupportFile{
		{Path: "1.crt", Content: "cert"},
		{Path: "1.key", Content: "key"},
	}); err != nil {
		t.Fatalf("writeCertFiles failed: %v", err)
	}

	if _, err := os.Stat(certDir); err != nil {
		t.Fatalf("expected cert dir to persist, stat err = %v", err)
	}
	if _, err := os.Stat(filepath.Join(certDir, "stale", "old.crt")); !os.IsNotExist(err) {
		t.Fatalf("expected stale cert file to be removed, stat err = %v", err)
	}
	if _, err := os.Stat(filepath.Join(certDir, "1.crt")); err != nil {
		t.Fatalf("expected new cert file to exist, stat err = %v", err)
	}
}

func TestEnsureLuaAssetsKeepsBaseDirAndRemovesStaleFiles(t *testing.T) {
	tempDir := t.TempDir()
	luaDir := filepath.Join(tempDir, "lua")
	if err := os.MkdirAll(filepath.Join(luaDir, "stale"), 0o755); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}
	if err := os.WriteFile(filepath.Join(luaDir, "stale", "old.lua"), []byte("old"), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	manager := &Manager{LuaDir: luaDir}

	if err := manager.EnsureLuaAssets(); err != nil {
		t.Fatalf("EnsureLuaAssets failed: %v", err)
	}

	if _, err := os.Stat(luaDir); err != nil {
		t.Fatalf("expected lua dir to persist, stat err = %v", err)
	}
	if _, err := os.Stat(filepath.Join(luaDir, "stale", "old.lua")); !os.IsNotExist(err) {
		t.Fatalf("expected stale lua file to be removed, stat err = %v", err)
	}
	if _, err := os.Stat(filepath.Join(luaDir, "log.lua")); err != nil {
		t.Fatalf("expected managed lua file to exist, stat err = %v", err)
	}
	if _, err := os.Stat(filepath.Join(luaDir, "pow", "check.lua")); err != nil {
		t.Fatalf("expected managed pow lua file to exist, stat err = %v", err)
	}
	if _, err := os.Stat(filepath.Join(luaDir, "pow", "static", "js", "main.mjs")); err != nil {
		t.Fatalf("expected managed pow static asset to exist, stat err = %v", err)
	}
}

func TestCertFileMode(t *testing.T) {
	testCases := []struct {
		path string
		want os.FileMode
	}{
		{path: "1.crt", want: 0o644},
		{path: "1.pem", want: 0o644},
		{path: "1.key", want: 0o600},
		{path: "misc.txt", want: 0o644},
	}

	for _, testCase := range testCases {
		if got := certFileMode(testCase.path); got != testCase.want {
			t.Fatalf("unexpected mode for %s: got %o want %o", testCase.path, got, testCase.want)
		}
	}
}

func TestManagerEnsureLuaAssetsWritesReadableFiles(t *testing.T) {
	tempDir := t.TempDir()
	manager := &Manager{
		LuaDir:           filepath.Join(tempDir, "lua"),
		NginxLuaDir:      "/etc/nginx/openflare-lua",
		RuntimeConfigDir: filepath.Join(tempDir, "runtime"),
	}

	err := manager.EnsureLuaAssets()
	if err != nil {
		t.Fatalf("EnsureLuaAssets failed: %v", err)
	}

	luaInfo, err := os.Stat(filepath.Join(manager.LuaDir, "log.lua"))
	if err != nil {
		t.Fatalf("failed to stat lua file: %v", err)
	}
	if luaInfo.Mode().Perm() != 0o644 {
		t.Fatalf("unexpected lua mode: %o", luaInfo.Mode().Perm())
	}
	if _, err := os.Stat(filepath.Join(manager.LuaDir, "pow", "check.lua")); err != nil {
		t.Fatalf("failed to stat pow lua file: %v", err)
	}
	data, err := os.ReadFile(filepath.Join(manager.LuaDir, "waf", "runtime.lua"))
	if err != nil {
		t.Fatalf("failed to read pow lua file: %v", err)
	}
	if !strings.Contains(string(data), filepath.ToSlash(manager.RuntimeConfigDir)) || !strings.Contains(string(data), `runtime_dir .. "/waf_config.json"`) {
		t.Fatalf("expected WAF runtime to load its worker snapshot from the runtime config dir, got %s", string(data))
	}
	ipGroupsData, err := os.ReadFile(filepath.Join(manager.LuaDir, "waf", "ip_groups.lua"))
	if err != nil {
		t.Fatalf("failed to read WAF IP group refresh module: %v", err)
	}
	if !strings.Contains(string(ipGroupsData), filepath.ToSlash(manager.RuntimeConfigDir)) || !strings.Contains(string(ipGroupsData), "waf_ip_groups.json.checksum") {
		t.Fatalf("expected IP group module to use the managed runtime checksum path, got %s", string(ipGroupsData))
	}
	if !strings.Contains(string(ipGroupsData), "openflare_waf_ip_groups") ||
		!strings.Contains(string(ipGroupsData), fmt.Sprintf("max_snapshot_bytes = options.max_snapshot_bytes or tonumber(\"%d\")", sharedprotocol.MaxWAFIPGroupSnapshotBytes)) {
		t.Fatalf("expected dedicated dictionary and shared protocol size limit in deployed IP group module, got %s", string(ipGroupsData))
	}
	powData, err := os.ReadFile(filepath.Join(manager.LuaDir, "pow", "runtime.lua"))
	if err != nil {
		t.Fatalf("failed to read pow lua file: %v", err)
	}
	if strings.Contains(string(powData), "io.open") {
		t.Fatalf("expected PoW node evaluation not to read configuration files, got %s", string(powData))
	}
}

func TestManagerEnsureLuaAssetsUsesConfiguredGeoIPDatabasePaths(t *testing.T) {
	tempDir := t.TempDir()
	manager := &Manager{
		LuaDir:       filepath.Join(tempDir, "lua"),
		MMDBPath:     "/custom/GeoLite2-Country.mmdb",
		CityMMDBPath: "/custom/GeoLite2-City.mmdb",
	}
	if err := manager.EnsureLuaAssets(); err != nil {
		t.Fatalf("EnsureLuaAssets failed: %v", err)
	}
	data, err := os.ReadFile(filepath.Join(manager.LuaDir, "waf", "runtime.lua"))
	if err != nil {
		t.Fatalf("read WAF runtime: %v", err)
	}
	for _, path := range []string{manager.MMDBPath, manager.CityMMDBPath} {
		if !strings.Contains(string(data), path) {
			t.Fatalf("expected configured GeoIP path %q in WAF runtime", path)
		}
	}
}

func TestEnsureLuaAssetsLeavesRuntimePowConfigOutsideLuaDir(t *testing.T) {
	tempDir := t.TempDir()
	luaDir := filepath.Join(tempDir, "lua")
	runtimeConfigDir := filepath.Join(tempDir, "runtime")
	if err := os.MkdirAll(runtimeConfigDir, 0o755); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}
	powConfigPath := filepath.Join(runtimeConfigDir, "pow_config.json")
	want := `[{"domains":["pow.example.com"],"enabled":true}]`
	if err := os.WriteFile(powConfigPath, []byte(want), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	manager := &Manager{LuaDir: luaDir, RuntimeConfigDir: runtimeConfigDir}

	if err := manager.EnsureLuaAssets(); err != nil {
		t.Fatalf("EnsureLuaAssets failed: %v", err)
	}

	got, err := os.ReadFile(powConfigPath)
	if err != nil {
		t.Fatalf("expected pow_config.json to remain after EnsureLuaAssets: %v", err)
	}
	if string(got) != want {
		t.Fatalf("unexpected pow_config.json content: got %s want %s", string(got), want)
	}
	if _, err := os.Stat(filepath.Join(luaDir, "pow_config.json")); !os.IsNotExist(err) {
		t.Fatalf("expected lua pow_config.json to stay absent, stat err = %v", err)
	}
}

func TestManagerApplyWritesPowConfigToRuntimeDirAndCleansLegacyCopies(t *testing.T) {
	tempDir := t.TempDir()
	certDir := filepath.Join(tempDir, "certs")
	luaDir := filepath.Join(tempDir, "lua")
	runtimeConfigDir := filepath.Join(tempDir, "runtime")
	for _, dir := range []string{certDir, luaDir, runtimeConfigDir} {
		if err := os.MkdirAll(dir, 0o755); err != nil {
			t.Fatalf("MkdirAll failed: %v", err)
		}
	}
	for _, path := range []string{filepath.Join(certDir, "pow_config.json"), filepath.Join(luaDir, "pow_config.json")} {
		if err := os.WriteFile(path, []byte("stale"), 0o644); err != nil {
			t.Fatalf("WriteFile failed: %v", err)
		}
	}
	manager := &Manager{
		MainConfigPath:   filepath.Join(tempDir, "nginx.conf"),
		RouteConfigPath:  filepath.Join(tempDir, "routes.conf"),
		CertDir:          certDir,
		LuaDir:           luaDir,
		RuntimeConfigDir: runtimeConfigDir,
		Executor:         &fakeExecutor{},
	}
	outcome := manager.Apply(context.Background(), "main", "route", []protocol.SupportFile{
		{Path: "pow_config.json", Content: "runtime"},
	})
	if outcome.Status != ApplyStatusSuccess {
		t.Fatalf("Apply failed: %#v", outcome)
	}
	data, err := os.ReadFile(filepath.Join(runtimeConfigDir, "pow_config.json"))
	if err != nil {
		t.Fatalf("failed to read runtime pow config: %v", err)
	}
	if string(data) != "runtime" {
		t.Fatalf("unexpected runtime pow config: %s", string(data))
	}
	for _, path := range []string{filepath.Join(certDir, "pow_config.json"), filepath.Join(luaDir, "pow_config.json")} {
		if _, err := os.Stat(path); !os.IsNotExist(err) {
			t.Fatalf("expected legacy pow config to be removed from %s, stat err = %v", path, err)
		}
	}
}

func TestManagerCurrentChecksumIncludesPowConfig(t *testing.T) {
	tempDir := t.TempDir()
	mainPath := filepath.Join(tempDir, "nginx.conf")
	routePath := filepath.Join(tempDir, "routes.conf")
	luaDir := filepath.Join(tempDir, "lua")
	runtimeConfigDir := filepath.Join(tempDir, "runtime")
	manager := &Manager{
		MainConfigPath:   mainPath,
		RouteConfigPath:  routePath,
		LuaDir:           luaDir,
		NginxLuaDir:      "/etc/nginx/openflare-lua",
		RuntimeConfigDir: runtimeConfigDir,
		Executor:         &fakeExecutor{},
	}

	outcome := manager.Apply(
		context.Background(),
		"access_log __OPENFLARE_ACCESS_LOG__ openflare_json;\n",
		"location /.within.website/x/cmd/anubis/static/ { alias __OPENFLARE_POW_STATIC_DIR__/; }\n",
		[]protocol.SupportFile{{Path: "pow_config.json", Content: `[{"domains":["pow.example.com"],"enabled":true}]`}},
	)
	if outcome.Status != ApplyStatusSuccess {
		t.Fatalf("Apply failed: %#v", outcome)
	}

	value, err := manager.CurrentChecksum()
	if err != nil {
		t.Fatalf("CurrentChecksum failed: %v", err)
	}
	expected := bundleChecksum(
		"access_log __OPENFLARE_ACCESS_LOG__ openflare_json;\n",
		"location /.within.website/x/cmd/anubis/static/ { alias __OPENFLARE_POW_STATIC_DIR__/; }\n",
		[]protocol.SupportFile{{Path: "pow_config.json", Content: `[{"domains":["pow.example.com"],"enabled":true}]`}},
	)
	if value != expected {
		t.Fatalf("unexpected checksum with pow config: got %s want %s", value, expected)
	}
}

func TestManagedPowLuaFilesUseInternalChallengeFlow(t *testing.T) {
	if !strings.Contains(openRestyPowRuntimeLua, `ngx.exec("/.within.website/x/cmd/anubis/api/make-challenge", challenge_args)`) {
		t.Fatal("expected pow runtime lua to internally execute make-challenge instead of issuing a 302 redirect")
	}
	if strings.Contains(openRestyPowRuntimeLua, "ngx.redirect(") {
		t.Fatal("expected pow runtime lua to avoid external redirects for challenge rendering")
	}
	if !strings.Contains(openRestyPowChallengeLua, `<h1 id="title" class="centered-div">`) {
		t.Fatal("expected challenge html to include Anubis-compatible title node")
	}
	if !strings.Contains(openRestyPowChallengeLua, `<div id="progress" role="progressbar" aria-labelledby="status"><div class="bar-inner"></div></div>`) {
		t.Fatal("expected challenge html to include Anubis-compatible progress markup")
	}
	if !strings.Contains(openRestyPowChallengeLua, `<script id="anubis_public_url" type="application/json">"__openflare_internal__"</script>`) {
		t.Fatal("expected challenge html to force Anubis frontend to reuse the current URL as redir target")
	}
	if !strings.Contains(openRestyPowRuntimeLua, `pow_sessions:set(session_key, "1", session_ttl)`) {
		t.Fatal("expected pow runtime lua to refresh the PoW session TTL on each valid request")
	}
	if !strings.Contains(openRestyPowRuntimeLua, `ngx.header["Set-Cookie"] = session_cookie(cookie_val, session_ttl)`) {
		t.Fatal("expected pow runtime lua to refresh the browser session cookie on each valid request")
	}
	if !strings.Contains(openRestyPowChallengeLua, `local session_ttl = config.session_ttl or 600`) {
		t.Fatal("expected challenge.lua to default session TTL to 10 minutes")
	}
	if !strings.Contains(openRestyPowVerifyLua, `local session_ttl = challenge_info.session_ttl or 600`) {
		t.Fatal("expected verify.lua to default session TTL to 10 minutes")
	}
	if !strings.Contains(openRestyPowVerifyLua, `if ngx.var.scheme == "https" then`) {
		t.Fatal("expected verify.lua to only mark the session cookie as Secure for HTTPS requests")
	}
}

func TestManagedPowLuaFilesPreserveConfigAcrossInternalRedirect(t *testing.T) {
	for _, expected := range []string{
		`pow_config_dict:set(config_key, cjson.encode(config)`,
		`openflare_pow_config_key = config_key`,
		`return false`,
	} {
		if !strings.Contains(openRestyPowRuntimeLua, expected) {
			t.Fatalf("expected PoW runtime to contain %q", expected)
		}
	}
	if !strings.Contains(openRestyPowChallengeLua, `pow_config_dict:get(config_key)`) {
		t.Fatal("expected challenge handler to restore reached PoW node config after internal redirect")
	}
}

func TestManagedWAFLuaExecutesCompiledGraphWithoutRequestIO(t *testing.T) {
	if !strings.Contains(openRestyWAFRuntimeLua, `node.type == "ip_match"`) {
		t.Fatal("expected WAF runtime to execute compiled IP match nodes")
	}
	if !strings.Contains(openRestyWAFRuntimeLua, `node.type == "ua_check"`) {
		t.Fatal("expected WAF runtime to execute compiled UA check nodes")
	}
	if !strings.Contains(openRestyWAFRuntimeLua, `node.type == "security_check"`) {
		t.Fatal("expected WAF runtime to execute compiled security check nodes")
	}
	checkStart := strings.Index(openRestyWAFRuntimeLua, "function _M.check()")
	if checkStart < 0 || strings.Contains(openRestyWAFRuntimeLua[checkStart:], "io.open") {
		t.Fatal("expected WAF request path not to perform file I/O")
	}
}

func TestManagerRollbackRestoresCertFiles(t *testing.T) {
	tempDir := t.TempDir()
	routePath := filepath.Join(tempDir, "routes.conf")
	mainPath := filepath.Join(tempDir, "nginx.conf")
	certDir := filepath.Join(tempDir, "certs")
	if err := os.MkdirAll(certDir, 0o755); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}
	if err := os.WriteFile(mainPath, []byte("old-main"), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	if err := os.WriteFile(routePath, []byte("old-route"), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	if err := os.WriteFile(filepath.Join(certDir, "1.crt"), []byte("old-cert"), 0o600); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	manager := &Manager{
		MainConfigPath:  mainPath,
		RouteConfigPath: routePath,
		CertDir:         certDir,
		NginxCertDir:    "/etc/nginx/openflare-certs",
		LuaDir:          filepath.Join(tempDir, "lua"),
		NginxLuaDir:     "/etc/nginx/openflare-lua",
		Executor: &fakeExecutor{
			reloadErr: errors.New("openresty reload failed"),
		},
	}

	outcome := manager.Apply(context.Background(), "new-main", "new-route", []protocol.SupportFile{
		{Path: "1.crt", Content: "new-cert"},
	})
	if outcome.Status != ApplyStatusFatal {
		t.Fatalf("expected fatal apply outcome, got %#v", outcome)
	}

	mainData, err := os.ReadFile(mainPath)
	if err != nil {
		t.Fatalf("failed to read main config: %v", err)
	}
	if string(mainData) != "old-main" {
		t.Fatalf("expected main rollback, got %s", string(mainData))
	}
	routeData, err := os.ReadFile(routePath)
	if err != nil {
		t.Fatalf("failed to read route config: %v", err)
	}
	if string(routeData) != "old-route" {
		t.Fatalf("expected route rollback, got %s", string(routeData))
	}
	certData, err := os.ReadFile(filepath.Join(certDir, "1.crt"))
	if err != nil {
		t.Fatalf("failed to read cert file: %v", err)
	}
	if string(certData) != "old-cert" {
		t.Fatalf("expected cert rollback, got %s", string(certData))
	}
}

func TestManagerApplyReturnsWarningWhenRollbackRecoversRuntime(t *testing.T) {
	tempDir := t.TempDir()
	routePath := filepath.Join(tempDir, "routes.conf")
	mainPath := filepath.Join(tempDir, "nginx.conf")
	certDir := filepath.Join(tempDir, "certs")
	if err := os.MkdirAll(certDir, 0o755); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}
	if err := os.WriteFile(mainPath, []byte("old-main"), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	if err := os.WriteFile(routePath, []byte("old-route"), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	if err := os.WriteFile(filepath.Join(certDir, "1.crt"), []byte("old-cert"), 0o600); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}
	manager := &Manager{
		MainConfigPath:  mainPath,
		RouteConfigPath: routePath,
		CertDir:         certDir,
		NginxCertDir:    "/etc/nginx/openflare-certs",
		LuaDir:          filepath.Join(tempDir, "lua"),
		NginxLuaDir:     "/etc/nginx/openflare-lua",
		Executor: &scriptedExecutor{
			reloadErrors: []error{errors.New("target config failed"), nil},
		},
	}

	outcome := manager.Apply(context.Background(), "new-main", "new-route", []protocol.SupportFile{
		{Path: "1.crt", Content: "new-cert"},
	})
	if outcome.Status != ApplyStatusWarning {
		t.Fatalf("expected warning apply outcome, got %#v", outcome)
	}

	mainData, err := os.ReadFile(mainPath)
	if err != nil {
		t.Fatalf("failed to read main config: %v", err)
	}
	if string(mainData) != "old-main" {
		t.Fatalf("expected main rollback, got %s", string(mainData))
	}
}

func TestManagerApplyStartsSafeFallbackWhenNoRollbackConfigExists(t *testing.T) {
	tempDir := t.TempDir()
	routePath := filepath.Join(tempDir, "routes.conf")
	mainPath := filepath.Join(tempDir, "nginx.conf")
	executor := &scriptedExecutor{
		testErrors: []error{errors.New("target config failed"), errors.New("rollback config missing"), nil},
	}
	manager := &Manager{
		MainConfigPath:               mainPath,
		RouteConfigPath:              routePath,
		OpenrestyObservabilityListen: "127.0.0.1:18081",
		Executor:                     executor,
	}

	outcome := manager.Apply(context.Background(), "bad-main", "bad-route", nil)
	if outcome.Status != ApplyStatusWarning {
		t.Fatalf("expected warning apply outcome, got %#v", outcome)
	}
	if !strings.Contains(outcome.Message, "fallback runtime started") {
		t.Fatalf("expected fallback message, got %q", outcome.Message)
	}
	if executor.testCalls != 3 {
		t.Fatalf("expected target, rollback, and fallback tests, got %d", executor.testCalls)
	}
	mainData, err := os.ReadFile(mainPath)
	if err != nil {
		t.Fatalf("failed to read main config: %v", err)
	}
	if !strings.Contains(string(mainData), "OpenFlare: No Valid Configuration") {
		t.Fatalf("expected safe fallback main config, got %s", string(mainData))
	}
	if !strings.Contains(string(mainData), "listen 80 default_server") {
		t.Fatalf("expected fallback to listen on port 80, got %s", string(mainData))
	}
	if !strings.Contains(string(mainData), "listen 127.0.0.1:18081") {
		t.Fatalf("expected fallback to expose local stub_status port, got %s", string(mainData))
	}
	if !strings.Contains(string(mainData), "stub_status;") {
		t.Fatalf("expected fallback to expose stub_status, got %s", string(mainData))
	}
	routeData, err := os.ReadFile(routePath)
	if err != nil {
		t.Fatalf("failed to read route config: %v", err)
	}
	if len(routeData) != 0 {
		t.Fatalf("expected fallback route config to be empty, got %q", string(routeData))
	}
}

func TestManagerCertFileTargetPathRejectsEscapes(t *testing.T) {
	manager := &Manager{CertDir: filepath.Join(t.TempDir(), "certs")}
	if err := os.MkdirAll(manager.CertDir, 0o755); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}

	absolutePath := "/tmp/evil.crt"
	if runtime.GOOS == "windows" {
		absolutePath = `C:/tmp/evil.crt`
	}

	testCases := []struct {
		path      string
		shouldErr bool
	}{
		{path: "nested/1.crt", shouldErr: false},
		{path: "../escape.crt", shouldErr: true},
		{path: "..\\escape.crt", shouldErr: true},
		{path: absolutePath, shouldErr: true},
		{path: "", shouldErr: true},
	}

	for _, testCase := range testCases {
		targetPath, err := manager.certFileTargetPath(testCase.path)
		if testCase.shouldErr {
			if err == nil {
				t.Fatalf("expected path %q to be rejected, got target %q", testCase.path, targetPath)
			}
			continue
		}
		if err != nil {
			t.Fatalf("expected path %q to be accepted: %v", testCase.path, err)
		}
		if !strings.HasPrefix(targetPath, manager.CertDir) {
			t.Fatalf("expected target path %q to stay under %q", targetPath, manager.CertDir)
		}
	}
}

func TestManagerApplyRejectsCertFilePathTraversal(t *testing.T) {
	tempDir := t.TempDir()
	manager := &Manager{
		MainConfigPath:  filepath.Join(tempDir, "nginx.conf"),
		RouteConfigPath: filepath.Join(tempDir, "routes.conf"),
		CertDir:         filepath.Join(tempDir, "certs"),
		NginxCertDir:    "/etc/nginx/openflare-certs",
		LuaDir:          filepath.Join(tempDir, "lua"),
		NginxLuaDir:     "/etc/nginx/openflare-lua",
		Executor:        &fakeExecutor{},
	}

	outcome := manager.Apply(context.Background(), "main", "route", []protocol.SupportFile{
		{Path: "../escape.crt", Content: "bad"},
	})
	if outcome.Status != ApplyStatusWarning {
		t.Fatalf("expected warning apply outcome, got %#v", outcome)
	}

	if _, statErr := os.Stat(filepath.Join(tempDir, "escape.crt")); !os.IsNotExist(statErr) {
		t.Fatalf("expected escaped file to not exist, stat err = %v", statErr)
	}
}

func TestManagerReconcileWAFIPGroupsRetainsUnchangedDeltaRuntimeFile(t *testing.T) {
	manager := &Manager{RuntimeConfigDir: t.TempDir()}

	if err := manager.ReconcileWAFIPGroups([]uint{1}, []protocol.WAFIPGroup{
		{ID: 1, Enabled: true, IPList: []string{"203.0.113.10"}, Checksum: "sum-1"},
	}); err != nil {
		t.Fatalf("ReconcileWAFIPGroups failed: %v", err)
	}
	if err := manager.ReconcileWAFIPGroups([]uint{1, 2}, []protocol.WAFIPGroup{
		{ID: 2, Enabled: true, IPList: []string{"198.51.100.10"}, Checksum: "sum-2"},
	}); err != nil {
		t.Fatalf("ReconcileWAFIPGroups second delta failed: %v", err)
	}

	checksums, err := manager.WAFIPGroupChecksums()
	if err != nil {
		t.Fatalf("WAFIPGroupChecksums failed: %v", err)
	}
	if checksums["1"] != "sum-1" || checksums["2"] != "sum-2" {
		t.Fatalf("expected merged checksums, got %#v", checksums)
	}
	data, err := os.ReadFile(filepath.Join(manager.RuntimeConfigDir, WAFIPGroupsConfigFileName))
	if err != nil {
		t.Fatalf("failed to read runtime ip group file: %v", err)
	}
	text := string(data)
	if !strings.Contains(text, "203.0.113.10") || !strings.Contains(text, "198.51.100.10") {
		t.Fatalf("expected runtime file to keep both groups, got %s", text)
	}
}

func TestManagerReconcileWAFIPGroupsConvergesToAuthoritativeTarget(t *testing.T) {
	runtimeDir := t.TempDir()
	manager := &Manager{RuntimeConfigDir: runtimeDir}
	initial, err := sharedprotocol.MarshalWAFIPGroupSnapshot(map[string]protocol.WAFIPGroup{
		"1":  {ID: 1, Name: "unchanged", Enabled: true, Checksum: "sum-1"},
		"2":  {ID: 2, Name: "old", Enabled: true, Checksum: "old-2"},
		"99": {ID: 99, Name: strings.Repeat("x", sharedprotocol.MaxWAFIPGroupSnapshotBytes-1024), Enabled: true, Checksum: "stale"},
	})
	if err != nil {
		t.Fatal(err)
	}
	if err = os.WriteFile(filepath.Join(runtimeDir, WAFIPGroupsConfigFileName), initial, 0o644); err != nil {
		t.Fatal(err)
	}

	if err = manager.ReconcileWAFIPGroups([]uint{1, 2}, []protocol.WAFIPGroup{{
		ID: 2, Name: "changed", Enabled: true, Checksum: "sum-2",
	}}); err != nil {
		t.Fatalf("ReconcileWAFIPGroups failed after pruning oversized stale data: %v", err)
	}
	config, err := manager.readWAFIPGroupsRuntimeConfig()
	if err != nil {
		t.Fatal(err)
	}
	if len(config.Groups) != 2 {
		t.Fatalf("authoritative group count = %d, want 2: %#v", len(config.Groups), config.Groups)
	}
	if got := config.Groups["1"].Name; got != "unchanged" {
		t.Fatalf("unchanged referenced group was not retained: %q", got)
	}
	if got := config.Groups["2"].Name; got != "changed" {
		t.Fatalf("changed referenced group was not merged: %q", got)
	}
	if _, exists := config.Groups["99"]; exists {
		t.Fatal("historical unreferenced group was not pruned")
	}
}

func TestManagerUpdateExistingWAFIPGroupsIgnoresUnrelatedBroadcast(t *testing.T) {
	runtimeDir := t.TempDir()
	manager := &Manager{RuntimeConfigDir: runtimeDir}
	if err := manager.ReconcileWAFIPGroups([]uint{1}, []protocol.WAFIPGroup{{ID: 1, Name: "old", Checksum: "old"}}); err != nil {
		t.Fatal(err)
	}
	if err := manager.UpdateExistingWAFIPGroups([]protocol.WAFIPGroup{
		{ID: 1, Name: "new", Checksum: "new"},
		{ID: 2, Name: "unrelated", Checksum: "sum-2"},
	}); err != nil {
		t.Fatal(err)
	}
	config, err := manager.readWAFIPGroupsRuntimeConfig()
	if err != nil {
		t.Fatal(err)
	}
	if len(config.Groups) != 1 || config.Groups["1"].Name != "new" {
		t.Fatalf("broadcast update escaped existing target: %#v", config.Groups)
	}
}

func TestManagerReconcileWAFIPGroupsPublishesRemovalOnlyAndEmptyTargets(t *testing.T) {
	runtimeDir := t.TempDir()
	manager := &Manager{RuntimeConfigDir: runtimeDir}
	if err := manager.ReconcileWAFIPGroups([]uint{1, 2}, []protocol.WAFIPGroup{
		{ID: 1, Checksum: "sum-1"}, {ID: 2, Checksum: "sum-2"},
	}); err != nil {
		t.Fatal(err)
	}
	before, err := os.ReadFile(filepath.Join(runtimeDir, WAFIPGroupsChecksumFileName))
	if err != nil {
		t.Fatal(err)
	}
	if err = manager.ReconcileWAFIPGroups([]uint{1}, nil); err != nil {
		t.Fatalf("removal-only reconcile failed: %v", err)
	}
	after, err := os.ReadFile(filepath.Join(runtimeDir, WAFIPGroupsChecksumFileName))
	if err != nil {
		t.Fatal(err)
	}
	if string(before) == string(after) {
		t.Fatal("removal-only reconcile did not publish a new checksum")
	}
	if err = manager.ReconcileWAFIPGroups(nil, nil); err != nil {
		t.Fatalf("empty authoritative reconcile failed: %v", err)
	}
	config, err := manager.readWAFIPGroupsRuntimeConfig()
	if err != nil {
		t.Fatal(err)
	}
	if len(config.Groups) != 0 {
		t.Fatalf("empty authoritative target retained groups: %#v", config.Groups)
	}
}

func TestManagerReconcileWAFIPGroupsRejectsMissingReferencedGroup(t *testing.T) {
	runtimeDir := t.TempDir()
	data := []byte(`{"groups":{"7":{"id":8,"checksum":"mistaken-match"}}}`)
	if err := os.WriteFile(filepath.Join(runtimeDir, WAFIPGroupsConfigFileName), data, 0o644); err != nil {
		t.Fatal(err)
	}
	manager := &Manager{RuntimeConfigDir: runtimeDir}
	checksums, err := manager.WAFIPGroupChecksums()
	if err != nil {
		t.Fatal(err)
	}
	if _, ok := checksums["7"]; ok {
		t.Fatalf("invalid local group was mistakenly reported matched: %#v", checksums)
	}
	err = manager.ReconcileWAFIPGroups([]uint{7}, nil)
	if err == nil || !strings.Contains(err.Error(), "missing referenced WAF IP group 7") {
		t.Fatalf("expected clear missing referenced group error, got %v", err)
	}
}

func TestWAFIPGroupChecksumPublishesJSONBeforeSidecar(t *testing.T) {
	runtimeDir := t.TempDir()
	var writes []string
	manager := &Manager{
		RuntimeConfigDir: runtimeDir,
		atomicFileWriter: func(path string, data []byte, perm os.FileMode) error {
			writes = append(writes, filepath.Base(path))
			return os.WriteFile(path, data, perm)
		},
	}

	if err := manager.ReconcileWAFIPGroups([]uint{1}, []protocol.WAFIPGroup{{
		ID: 1, Enabled: true, IPList: []string{"203.0.113.10"}, Checksum: "sum-1",
	}}); err != nil {
		t.Fatalf("SyncWAFIPGroups failed: %v", err)
	}
	if got, want := strings.Join(writes, ","), WAFIPGroupsConfigFileName+","+WAFIPGroupsChecksumFileName; got != want {
		t.Fatalf("expected JSON then checksum publication, got %s", got)
	}
	jsonData, err := os.ReadFile(filepath.Join(runtimeDir, WAFIPGroupsConfigFileName))
	if err != nil {
		t.Fatalf("read JSON snapshot: %v", err)
	}
	checksumData, err := os.ReadFile(filepath.Join(runtimeDir, WAFIPGroupsChecksumFileName))
	if err != nil {
		t.Fatalf("read checksum sidecar: %v", err)
	}
	if got, want := strings.TrimSpace(string(checksumData)), checksum(string(jsonData)); got != want {
		t.Fatalf("checksum mismatch: got %q want %q", got, want)
	}
}

func TestWAFIPGroupChecksumJSONFailurePreservesOldSidecar(t *testing.T) {
	runtimeDir := t.TempDir()
	checksumPath := filepath.Join(runtimeDir, WAFIPGroupsChecksumFileName)
	if err := os.WriteFile(checksumPath, []byte("old-checksum\n"), 0o644); err != nil {
		t.Fatal(err)
	}
	manager := &Manager{
		RuntimeConfigDir: runtimeDir,
		atomicFileWriter: func(path string, _ []byte, _ os.FileMode) error {
			if filepath.Base(path) == WAFIPGroupsConfigFileName {
				return errors.New("json rename failed")
			}
			return errors.New("checksum must not be written")
		},
	}

	if err := manager.ReconcileWAFIPGroups([]uint{1}, []protocol.WAFIPGroup{{ID: 1, Checksum: "sum-1"}}); err == nil {
		t.Fatal("expected JSON publication failure")
	}
	data, err := os.ReadFile(checksumPath)
	if err != nil || string(data) != "old-checksum\n" {
		t.Fatalf("old checksum must remain unchanged, data=%q err=%v", data, err)
	}
}

func TestWAFIPGroupChecksumBootstrapsLegacySnapshot(t *testing.T) {
	runtimeDir := t.TempDir()
	jsonData := []byte(`{"groups":{"7":{"id":7,"enabled":true,"checksum":"sum-7"}}}`)
	if err := os.WriteFile(filepath.Join(runtimeDir, WAFIPGroupsConfigFileName), jsonData, 0o644); err != nil {
		t.Fatal(err)
	}
	manager := &Manager{RuntimeConfigDir: runtimeDir}

	checksums, err := manager.WAFIPGroupChecksums()
	if err != nil {
		t.Fatalf("WAFIPGroupChecksums failed: %v", err)
	}
	if checksums["7"] != "sum-7" {
		t.Fatalf("unexpected group checksums: %#v", checksums)
	}
	sidecar, err := os.ReadFile(filepath.Join(runtimeDir, WAFIPGroupsChecksumFileName))
	if err != nil {
		t.Fatalf("legacy checksum sidecar was not created: %v", err)
	}
	if got, want := strings.TrimSpace(string(sidecar)), checksum(string(jsonData)); got != want {
		t.Fatalf("legacy checksum mismatch: got %q want %q", got, want)
	}
}

func TestWAFIPGroupChecksumRepairsStaleSidecar(t *testing.T) {
	runtimeDir := t.TempDir()
	jsonData := []byte(`{"groups":{"9":{"id":9,"enabled":true,"checksum":"sum-9"}}}`)
	if err := os.WriteFile(filepath.Join(runtimeDir, WAFIPGroupsConfigFileName), jsonData, 0o644); err != nil {
		t.Fatal(err)
	}
	checksumPath := filepath.Join(runtimeDir, WAFIPGroupsChecksumFileName)
	if err := os.WriteFile(checksumPath, []byte("stale-checksum\n"), 0o644); err != nil {
		t.Fatal(err)
	}
	manager := &Manager{RuntimeConfigDir: runtimeDir}

	if _, err := manager.WAFIPGroupChecksums(); err != nil {
		t.Fatalf("WAFIPGroupChecksums failed: %v", err)
	}
	sidecar, err := os.ReadFile(checksumPath)
	if err != nil {
		t.Fatalf("read repaired checksum: %v", err)
	}
	if got, want := strings.TrimSpace(string(sidecar)), checksum(string(jsonData)); got != want {
		t.Fatalf("stale checksum was not repaired: got %q want %q", got, want)
	}
}

func TestWAFIPGroupSnapshotRejectsOversizeBeforePublication(t *testing.T) {
	runtimeDir := t.TempDir()
	jsonPath := filepath.Join(runtimeDir, WAFIPGroupsConfigFileName)
	checksumPath := filepath.Join(runtimeDir, WAFIPGroupsChecksumFileName)
	oldJSON := []byte(`{"groups":{"1":{"id":1,"enabled":true,"checksum":"old"}}}`)
	oldChecksum := []byte("old-checksum\n")
	if err := os.WriteFile(jsonPath, oldJSON, 0o644); err != nil {
		t.Fatal(err)
	}
	if err := os.WriteFile(checksumPath, oldChecksum, 0o644); err != nil {
		t.Fatal(err)
	}
	manager := &Manager{RuntimeConfigDir: runtimeDir}

	err := manager.ReconcileWAFIPGroups([]uint{1, 2}, []protocol.WAFIPGroup{{
		ID: 2, Name: strings.Repeat("x", sharedprotocol.MaxWAFIPGroupSnapshotBytes), Enabled: true, Checksum: "new",
	}})
	if err == nil || !strings.Contains(err.Error(), "exceeds maximum") {
		t.Fatalf("expected clear oversized snapshot error, got %v", err)
	}
	if got, readErr := os.ReadFile(jsonPath); readErr != nil || string(got) != string(oldJSON) {
		t.Fatalf("oversized snapshot touched committed JSON, got=%q err=%v", got, readErr)
	}
	if got, readErr := os.ReadFile(checksumPath); readErr != nil || string(got) != string(oldChecksum) {
		t.Fatalf("oversized snapshot touched committed checksum, got=%q err=%v", got, readErr)
	}
}

func TestObservabilityListenAddress(t *testing.T) {
	if got := ObservabilityListenAddress(18081); got != "127.0.0.1:18081" {
		t.Fatalf("unexpected default observability listen address: %s", got)
	}
	if got := ObservabilityListenAddress(18081); got != "127.0.0.1:18081" {
		t.Fatalf("unexpected path observability listen address: %s", got)
	}
}

func TestEnsureWorldTraversableChainFixesRestrictedParentDirs(t *testing.T) {
	tempDir := t.TempDir()
	dataDir := filepath.Join(tempDir, "data")
	runtimeDir := filepath.Join(dataDir, "etc", "openflare")
	if err := os.MkdirAll(runtimeDir, 0o700); err != nil {
		t.Fatalf("MkdirAll failed: %v", err)
	}
	configPath := filepath.Join(runtimeDir, "waf_config.json")
	if err := os.WriteFile(configPath, []byte(`{}`), 0o644); err != nil {
		t.Fatalf("WriteFile failed: %v", err)
	}

	if err := EnsureWorldTraversablePath(runtimeDir); err != nil {
		t.Fatalf("EnsureWorldTraversablePath failed: %v", err)
	}

	info, err := os.Stat(filepath.Join(dataDir, "etc"))
	if err != nil {
		t.Fatalf("Stat failed: %v", err)
	}
	if info.Mode().Perm()&0o005 == 0 {
		t.Fatalf("expected etc directory to be world-traversable, got %o", info.Mode().Perm())
	}
}